Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save file fails on network folder after updating to 8.1.950 (155) #861

Closed
ekortright opened this issue Feb 19, 2019 · 7 comments
Closed
Milestone

Comments

@ekortright
Copy link

ekortright commented Feb 19, 2019

I can no longer save changes to files on network folders after updating MacVim to Custom Version 8.1.950 (155). I am on Mac OS X 10.13.6. I have several network shares mounted as smbfs.

After trying to save a file, the changes are not saved, the buffer shows as still modified, and I get an error: E667: Fsync failed

I tried restarting MacVim after removing .vimrc, as well as doing defaults delete org.vim.MacVim, but nothing helps.

MacVim can save changes to files on my local disk with no problems. Also, the system vim (/usr/bin/vim) can save files to local or network files with no problems.

Nothing has changed on my machine, other than updating MacVim.

@ychin ychin added this to the snapshot-156 milestone Feb 20, 2019
@ychin
Copy link
Member

ychin commented Feb 20, 2019

Seems like v8.1.0915 (vim/vim@a787019) broke this. I will file a pull request with Vim to fix this.

@ychin
Copy link
Member

ychin commented Feb 20, 2019

I filed vim/vim#4016 so hopefully it will get merged in. The next version (snapshot-156) should have this fix. Meanwhile you could use an older version while waiting for this to get fixed (on Vim, then merged to MacVim).

@ekortright
Copy link
Author

Thank you for such a quick response! I will go back to pre-8.1.0915 for now since it is hard to imagine life without MacVim. :^)

@ychin
Copy link
Member

ychin commented Feb 22, 2019

This is currently fixed in Vim and the next version will have the fix. If you want to go back to 8.1.0950, you can do set nofsync but it's a temporary solution. If you are happy with the previous version maybe just use that for now until the next update.

@ekortright
Copy link
Author

ekortright commented Feb 22, 2019 via email

ychin added a commit to ychin/macvim that referenced this issue Jun 11, 2019
Vim patch 8.1.1517

Security Fixes:

- Fix modeline security vulnerability (CVE-2019-12735). macvim-dev#898 (fixed in
  Vim 8.1.265)

Features:

- Add new option 'MMTitlebarAppearsTransparent' that will make the title
  bar transparent and use the background color in the color scheme
  (10.14 or above only). macvim-dev#888

Fixes:

- Fix filename parsing error when opening a file with special characters
  like '$' in file path. macvim-dev#863
- Fix blurry I-beam mouse cursor. macvim-dev#755
- Fix silently failing to save a file when conversion error is present.
  macvim-dev#671. (Vim 8.1.1349)
- Fix failing to save to a network shared SMB folder macvim-dev#861.
  (Vim 8.1.0957)

Misc:

- 'guitablabel' can now be set in .vimrc, without MacVim overriding it.
  macvim-dev#899

Targets macOS 10.8+

Script interfaces have compatibility with these versions:

- Lua 5.3
- Perl 5.18
- Python2 2.7
- Python3 3.7
- Ruby 2.6
@ychin
Copy link
Member

ychin commented Jun 11, 2019

Sorry for the delays, but the I have just released a new version for MacVim and it should have fixed this issue. @ekortright feel free to upgrade to 8.1.157 (snapshot 156).

@ychin ychin closed this as completed Jun 11, 2019
@ekortright
Copy link
Author

Thank you very much. I will do that.

ichizok pushed a commit to ichizok/macvim that referenced this issue Jun 8, 2020
Problem:    Search() cannot skip over matches like searchpair() can.
Solution:   Add an optional "skip" argument. (Christian Brabandt, closes macvim-dev#861)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants