Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

menu bar not hide ']' prefix item #853

Closed
epheien opened this issue Feb 14, 2019 · 4 comments · Fixed by #911
Closed

menu bar not hide ']' prefix item #853

epheien opened this issue Feb 14, 2019 · 4 comments · Fixed by #911
Labels
Feature Request New features request. Not an existing issue or bug.
Milestone
snapshot-157

Comments

@epheien
Copy link

epheien commented Feb 14, 2019 

:amenu ]Toolbar.Make	:make<CR>
:popup ]Toolbar

expect menu bar not show ]Toolbar, but I show
@ychin ychin added this to the snapshot-156 milestone Feb 18, 2019
@ychin ychin added the Feature Request New features request. Not an existing issue or bug. label Feb 22, 2019
@ychin ychin modified the milestones: snapshot-156, snapshot-157 Jun 9, 2019
@eirnym
Copy link
Contributor

eirnym commented Jun 13, 2019

@epheien Why do you need ] character in menu title? I haven't found any documentation about processing this character in menu title by vim or MacVim

@epheien
Copy link
Author

epheien commented Jun 14, 2019 •
edited
Loading

@epheien Why do you need ] character in menu title? I haven't found any documentation about processing this character in menu title by vim or MacVim

:h :popup

@eirnym
Copy link
Contributor

eirnym commented Jun 14, 2019

Thank you, I missed it

@eirnym
Copy link
Contributor

eirnym commented Jun 16, 2019 •
edited
Loading

Any other implementation of Vim GUI ignores name completely. Only this implementation uses it.

GTK formally have name for popup menu, but it is always Input Methods.

So we can file an issue to the Vim repo that MacVim is the only implementation which shows title for popup menu :D
PS: also W32 shows this description

eirnym pushed a commit to eirnym/macvim that referenced this issue Jun 16, 2019
Hide MNU_HIDDEN_CHAR prefix from menu title if present
cd38b6c 
Closes: macvim-dev#853
@eirnym eirnym mentioned this issue Jun 16, 2019
Merged
eirnym pushed a commit to eirnym/macvim that referenced this issue Jun 17, 2019
Hide MNU_HIDDEN_CHAR prefix from menu title if present
e58b970 
Closes: macvim-dev#853
@ychin ychin closed this as completed in #911 Jul 7, 2019
ychin added a commit to ychin/macvim that referenced this issue Jul 21, 2019
@ychin
MacVim Snapshot 157
e3e31bb 
Vim patch 8.1.1722

Features:

- Add 'MMDisableLaunchAnimation' option to disable the opening animation
  of MacVim Windows. macvim-dev#915
- Make 'MMTitlebarAppearsTransparent' work in pre-Mojave macOS versions.
  macvim-dev#917

Fixes:

- Fix issue where MacVim would freeze when opening a file already opened
  in another MacVim window when swap files are enabled. macvim-dev#913
- Menu items with name starting with ']' now properly get hidden in the
  main menu bar (see `:help hidden-menus`). macvim-dev#853

Targets macOS 10.8+

Script interfaces have compatibility with these versions:

- Lua 5.3
- Perl 5.18
- Python2 2.7
- Python3 3.7
- Ruby 2.6
ychin added a commit that referenced this issue Jul 28, 2019
@ychin
MacVim Snapshot 157
1776f34 
Vim patch 8.1.1722

Features:

- Add 'MMDisableLaunchAnimation' option to disable the opening animation
  of MacVim Windows. #915
- Make 'MMTitlebarAppearsTransparent' work in pre-Mojave macOS versions.
  #917

Fixes:

- Fix issue where MacVim would freeze when opening a file already opened
  in another MacVim window when swap files are enabled. #913
- Menu items with name starting with ']' now properly get hidden in the
  main menu bar (see `:help hidden-menus`). #853

Targets macOS 10.8+

Script interfaces have compatibility with these versions:

- Lua 5.3
- Perl 5.18
- Python2 2.7
- Python3 3.7
- Ruby 2.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request New features request. Not an existing issue or bug.
Projects
None yet
Milestone
snapshot-157
Development

Successfully merging a pull request may close this issue.

Hide MNU_HIDDEN_CHAR prefix from menu title if present eirnym/macvim
3 participants
@eirnym @ychin @epheien