Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign MacVim Builds #517

Closed
cycloon opened this issue Jun 28, 2017 · 10 comments
Closed

Sign MacVim Builds #517

cycloon opened this issue Jun 28, 2017 · 10 comments
Labels
Updater Issues related to Sparkle updater
Milestone
snapshot-154

Comments

@cycloon
Copy link

cycloon commented Jun 28, 2017

It looks like MacVim.app is not signed. I get "MacVim.app can't be opened because it is from an unidentified developer."

As this is a first barrier for new users, please sign the binary.
@splhack
Copy link
Contributor

splhack commented Jul 23, 2017

I don't have Apple Developer Program.

@splhack splhack closed this as completed Jul 23, 2017
@EarthCitizen
Copy link

My work laptop is locked down, so no possible way to use MacVim.

@ychin
Copy link
Member

ychin commented Dec 4, 2018

Reopen for investigation.

@ychin ychin reopened this Dec 4, 2018
@chdiza
Copy link
Contributor

chdiza commented Dec 4, 2018

I'm opposed to this if it means we won't be able to build it on our own machines without a Developer Cert.

@ychin
Copy link
Member

ychin commented Dec 4, 2018 •
edited
Loading

MacVim is open-sourced so you can always still build it yourself :). We also still need to support Homebrew builds (which builds from source) of course.

Part of the investigation is coming up with a satisfactory way to enable code signing in the build system (Travis CI) while keeping the main Xcode project in the repo pristine.

I do think for distributed binary we should try to sign it. Sparkle (our update system) already checks for a code signature but it’s nice to have an Apple-signed binary for peace of mind (not to mention Apple is heavily encouraging this which makes the first-time user experience quite annoying otherwise).

As a side note, #763 is related to this for some weird reason. I suspect the fact that MacVim is unsigned causes some slow validation path to trigger in Mojave when calling external application.

@chdiza
Copy link
Contributor

chdiza commented Dec 4, 2018

Well, Hammerspoon is also open-source, but if I want to build it from source and not have it be a console-spamming debug build, I have to make a self-signed cert and "sign" it with that. What a PITA; I hope this never happens to MacVim.

@ychin
Copy link
Member

ychin commented Dec 5, 2018

I think this is because Hammerspoon requires system permission which would be annoying if you don’t self-sign the app. So a little bit of a different circumstance from MacVim.

@ychin ychin mentioned this issue Dec 5, 2018
Closed
@ychin ychin added the Updater Issues related to Sparkle updater label Dec 12, 2018
@ychin ychin added this to the snapshot-154 milestone Dec 19, 2018
@ychin ychin mentioned this issue Dec 22, 2018
Closed
@eirnym
Copy link
Contributor

eirnym commented Dec 29, 2018

Could we accept a limited amount of donations for this purpose?

@ychin
Copy link
Member

ychin commented Dec 30, 2018

I thought about it but I have already purchased an account. Maybe I’ll do it next year for renewal.

ychin added a commit to ychin/macvim that referenced this issue Feb 4, 2019
@ychin
MacVim Snapshot 154
644ca93 
Vim patch 8.1.873

Targets macOS 10.8+

General:

- MacVim binary is now signed by a Developer ID (macvim-dev#517). This makes it
  easier to download and run the app without security warnings.
    - This also fixes an issue where invoking external programs via
      `:!open` was slow in Mojave. macvim-dev#763
- Ruby version has been updated from 2.5 to 2.6.

Fixes:

- Scrollbars are no longer misplaced when resizing window macvim-dev#827
- Fix rendering performance issues for commands (e.g. `:version`,
  `:echo`, or `:!`) that echo text in Mojave macvim-dev#840
- MacVim now properly asks for permission to use AppleEvent (ODB Editor
  Suite requires that to work) macvim-dev#822
- Fix borderless window mode in pre-Mojave versions macvim-dev#828

Script interfaces have compatibility with these versions:

- Lua 5.3
- Perl 5.18
- Python2 2.7
- Python3 3.7
- Ruby 2.6
@ychin
Copy link
Member

ychin commented Feb 4, 2019

Latest release (https://github.com/macvim-dev/macvim/releases/tag/snapshot-154) now signs the app.

@ychin ychin closed this as completed Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Updater Issues related to Sparkle updater
Projects
None yet
Milestone
snapshot-154
Development

No branches or pull requests
6 participants
@splhack @cycloon @eirnym @EarthCitizen @ychin @chdiza