Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big Sur TouchBar warnings #1114

Closed
dim13 opened this issue Nov 14, 2020 · 14 comments
Closed

Big Sur TouchBar warnings #1114

dim13 opened this issue Nov 14, 2020 · 14 comments

Comments

@dim13
Copy link

dim13 commented Nov 14, 2020

Describe the bug

Warnings logged to console:

2020-11-14 12:04:30.383 MacVim[38128:287979] Warning: Expected min height of view: (<MMTouchBarButton: 0x7fb601061200>) to be less than or equal to 30 but got a height of 32.000000. This error will be logged once per view in violation.
2020-11-14 12:04:31.160 MacVim[38128:287979] Warning: Expected min height of view: (<NSPopoverTouchBarItemButton: 0x7fb5fee3bf50>) to be less than or equal to 30 but got a height of 32.000000. This error will be logged once per view in violation.
2020-11-14 12:04:42.433 MacVim[38128:287979] Warning: Expected min height of view: (<NSPopoverTouchBarItemButton: 0x7fb5feed2410>) to be less than or equal to 30 but got a height of 32.000000. This error will be logged once per view in violation.
2020-11-14 12:04:43.095 MacVim[38128:287979] Warning: Expected min height of view: (<NSPopoverTouchBarItemButton: 0x7fb6010b59c0>) to be less than or equal to 30 but got a height of 32.000000. This error will be logged once per view in violation.
2020-11-14 12:10:40.174 MacVim[38128:287979] Warning: Expected min height of view: (<NSPopoverTouchBarItemButton: 0x7fb5feedb5e0>) to be less than or equal to 30 but got a height of 32.000000. This error will be logged once per view in violation.

Environment (please complete the following information):

  • VIM: 8.2.1719 (166)
  • OS: Big Sur 11.0.1
@iywey
Copy link

iywey commented Nov 16, 2020

Have the same issue! Always happens when switching between modes it seems.

@ychin
Copy link
Member

ychin commented Nov 23, 2020

Yeah I'm not sure why this is happening. Need to take a look. I'm guessing Apple made the buttons larger so they went over the limit…

@tioguerra
Copy link

While this issue is not fixed, is there a way to suppress these warnings from appearing on the terminal?

@ychin
Copy link
Member

ychin commented Nov 30, 2020

Sorry, I'm not sure if there is a way to suppress the warnings.

I just tested this, and it seems that for local testing, when I build MacVim using Xcode 12 (current released binary is built using Xcode 11), the issue seems to go away, so I think it's just a matter of building MacVim with the latest SDK.

I plan to make a release soon, so hopefully you don't have to suffer this too long.

@ychin ychin added this to the snapshot-167 milestone Nov 30, 2020
@ekzotech
Copy link

ekzotech commented Dec 1, 2020

Found this issue 2 days ago, got same message after upgrading to BigSur.
After last comment I tried to remove MacVim and reinstall it with Homebrew. Now all warnings are gone, everything is ok. Using Xcode 12 in my system.
So thank you very much, @ychin for your idea about building with Xcode 12.

@callumfrance
Copy link

Thanks @ekzotech ! For people looking for a step-by-step, I fixed this by doing the following:

  • Updating my brew update and brew upgrade
  • Updating to the newer command line tools (CLT) sudo rm -rf /Library/Developer/CommandLineTools and sudo xcode-select --install
  • Uninstalling my macvim brew uninstall macvim
  • Reinstalling macvim brew install macvim

@balena
Copy link

balena commented Dec 2, 2020

@callumfrance: didn't work for me.

@callumfrance
Copy link

@balena unlucky bro

@jcampbell1710
Copy link

Thanks @ekzotech ! For people looking for a step-by-step, I fixed this by doing the following:

  • Updating my brew update and brew upgrade
  • Updating to the newer command line tools (CLT) sudo rm -rf /Library/Developer/CommandLineTools and sudo xcode-select --install
  • Uninstalling my macvim brew uninstall macvim
  • Reinstalling macvim brew install macvim

Worked for me!

@xbot
Copy link

xbot commented Dec 5, 2020

Thanks @ekzotech brew reinstall macvim works for me.

@eirnym
Copy link
Contributor

eirnym commented Dec 7, 2020

https://developer.apple.com/design/human-interface-guidelines/macos/touch-bar/touch-bar-icons-and-images/

ideal icon size: 36px × 36px (18pt × 18pt @2x)
maximum icon size: 44px × 44px (22pt × 22pt @2x)

@eirnym
Copy link
Contributor

eirnym commented Dec 7, 2020

Other apps has the same problem, according on search results in google

ychin added a commit that referenced this issue Dec 11, 2020
Updated to Vim 8.2.2127.

*Note*: This release doesn't natively support Apple Silicon / M1 yet, but
does work under Rosetta. See below.

Features
====================

Big Sur / macOS 11
--------------------

- MacVim now has an updated app icon (#1054), and preference pane / toolbars
  have been updated to match Big Sur's interface guidelines. (#1128)
- Fixed Touch Bar warnings when launching MacVim from the terminal.
  #1114
- SF Symbol characters will show up properly as double-width as most of
  these icons would take up more than one column. Note that these
  characters are specific to macOS and would not work in other
  platforms. #1129

Renderer / scrolling performance improvements
--------------------

The Core Text renderer has been rewritten and is now much faster!
Scrolling should not stutter and lag like before and generally it should
feel a lot smoother now. Thanks to Sidney San Martín (@s4y) for the
contribution. #858

With this change, the non-Core-Text renderer is now considered
deprecated. The old renderer is accessible either through the Preference
Pane (under Advanced) or by setting the defaults "MMRenderer" to 0. It
works for now, but it will be removed in a future update as it has known
bugs.

Menu Localization
--------------------

Menus are now localized, see `:h langmenu` for how Vim menu localization
works. You can use `set langmenu=none` to turn it off if you would like. #1099

There still exists a few menu items that are not localized, and the
general MacVim GUI is not localized as well. If you would like to help,
please use #1102 to coordinate with MacVim dev team.

Getting help / Help menu
--------------------

- Help menu's search bar now searches Vim documentation as well! See
  #1095.
- Vimtutor is now bundled with MacVim, and you can access vimtutor from
  the Help menu (#1096). There is also a link to the latest release
  notes as well (#1131).

General
====================

- This release does not contain a native universal app for Apple Silicon
  / M1 Macs yet. The release binary will still work under Rosetta, which
  should provide enough performance, but if you use Python/etc plugins,
  you need to make sure you have x86 versions of Python/etc installed
  (which is still the default for Homebrew as of this release).

  MacVim is buildable under Apple Silicon, so if you need a native
  binary, you could build it yourself by downloading the source from the
  Github repository. See #1136 for progress on releasing a universal app
  for Apple Silicon.

- MacVim has enabled the Github Discussions feature, which serves as a
  good spot for general discussions and questions. See
  #1130 and check it
  out!

Fixes
====================

- Launching MacVim from the Dock with locales that use "," for decimal
  separators now works correctly. #11 (Vim 8.2.1738)
- `WinBar` menus (which are used by plugins like vimspector) now work
  properly and don't create dummy menu items. #918
- Using `:browse tabnew` no longer crashes MacVim in terminal mode.
  #1107 (Vim 8.2.1842)

Misc
====================

- Scripting languages versions:
    - Python is now built against 3.9, up from 3.8.
    - Lua is now built against 5.4, up from 5.3.

Compatibility
====================

Requires macOS 10.9 or above.

Script interfaces have compatibility with these versions:

- Lua 5.4
- Perl 5.18
- Python2 2.7
- Python3 3.9
- Ruby 2.7
ychin added a commit that referenced this issue Dec 12, 2020
Updated to Vim 8.2.2127.

*Note*: This release doesn't natively support Apple Silicon / M1 yet, but
does work under Rosetta. See below.

Features
====================

Big Sur / macOS 11
--------------------

- MacVim now has an updated app icon (#1054), and preference pane / toolbars
  have been updated to match Big Sur's interface guidelines. (#1128)
- Fixed Touch Bar warnings when launching MacVim from the terminal.
  #1114
- SF Symbol characters will show up properly as double-width as most of
  these icons would take up more than one column. Note that these
  characters are specific to macOS and would not work in other
  platforms. #1129

Renderer / scrolling performance improvements
--------------------

The Core Text renderer has been rewritten and is now much faster!
Scrolling should not stutter and lag like before and generally it should
feel a lot smoother now. Thanks to Sidney San Martín (@s4y) for the
contribution. #858

With this change, the non-Core-Text renderer is now considered
deprecated. The old renderer is accessible either through the Preference
Pane (under Advanced) or by setting the defaults "MMRenderer" to 0. It
works for now, but it will be removed in a future update as it has known
bugs.

Menu Localization
--------------------

Menus are now localized, see `:h langmenu` for how Vim menu localization
works. You can use `set langmenu=none` to turn it off if you would like. #1099

There still exists a few menu items that are not localized, and the
general MacVim GUI is not localized as well. If you would like to help,
please use #1102 to coordinate with MacVim dev team.

Getting help / Help menu
--------------------

- Help menu's search bar now searches Vim documentation as well! See
  #1095.
- Vimtutor is now bundled with MacVim, and you can access vimtutor from
  the Help menu (#1096). There is also a link to the latest release
  notes as well (#1131).

General
====================

- This release does not contain a native universal app for Apple Silicon
  / M1 Macs yet. The release binary will still work under Rosetta, which
  should provide enough performance, but if you use Python/etc plugins,
  you need to make sure you have x86 versions of Python/etc installed
  (which is still the default for Homebrew as of this release).

  MacVim is buildable under Apple Silicon, so if you need a native
  binary, you could build it yourself by downloading the source from the
  Github repository. See #1136 for progress on releasing a universal app
  for Apple Silicon.

- MacVim has enabled the Github Discussions feature, which serves as a
  good spot for general discussions and questions. See
  #1130 and check it
  out!

Fixes
====================

- Launching MacVim from the Dock with locales that use "," for decimal
  separators now works correctly. #11 (Vim 8.2.1738)
- `WinBar` menus (which are used by plugins like vimspector) now work
  properly and don't create dummy menu items. #918
- Using `:browse tabnew` no longer crashes MacVim in terminal mode.
  #1107 (Vim 8.2.1842)

Misc
====================

- Scripting languages versions:
    - Python is now built against 3.9, up from 3.8.
    - Lua is now built against 5.4, up from 5.3.

Compatibility
====================

Requires macOS 10.9 or above.

Script interfaces have compatibility with these versions:

- Lua 5.4
- Perl 5.18
- Python2 2.7
- Python3 3.9
- Ruby 2.7
@ychin
Copy link
Member

ychin commented Dec 12, 2020

This should be fixed with the latest release since it's built with Xcode 12.

@ychin ychin closed this as completed Dec 12, 2020
@ucb-pb
Copy link

ucb-pb commented Feb 17, 2021

@callumfrance: didn't work for me.

Try reinstalling the CLT first because brew was giving me an error about it. Also, adding --verbose to brew update or brew update can be helpful. I thought it was just hanging at first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests