Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for hmmratac to use BEDPE files as input #580

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Add option for hmmratac to use BEDPE files as input #580

merged 1 commit into from
Aug 3, 2023

Conversation

taoliu
Copy link
Contributor

@taoliu taoliu commented Aug 3, 2023

We changed some options for hmmratac:

  1. -b has been changed to -i to accept input files.
  2. -f option is added to allow users to specify the format of input files to be either BAMPE or BEDPE.
  3. Testing has been added for -f BEDPE of hmmratac.

@taoliu taoliu linked an issue Aug 3, 2023 that may be closed by this pull request
Feat: Support for CRAM #578
Open
@taoliu taoliu self-assigned this Aug 3, 2023
philippadoherty
philippadoherty reviewed Aug 3, 2023
View reviewed changes
Copy link
Contributor

@philippadoherty philippadoherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I've made a note to update the hmmratac documentation for next release

@taoliu
Copy link
Contributor Author

taoliu commented Aug 3, 2023

Looks good, I've made a note to update the hmmratac documentation for next release

Thanks!

@taoliu taoliu merged commit 663cff0 into master Aug 3, 2023
@taoliu taoliu mentioned this pull request Aug 3, 2023
Open
@bcantarel
Copy link

Thanks so much for this speedy work around!!

@taoliu taoliu deleted the feat/macs3/hmmratac-bedpe branch August 14, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippadoherty philippadoherty philippadoherty left review comments

Assignees

@taoliu taoliu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: Support for CRAM
3 participants
@taoliu @bcantarel @philippadoherty