Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WACS #283

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

WACS #283

wants to merge 30 commits into from

Conversation

aawdeh
Copy link

@aawdeh aawdeh commented Mar 31, 2019

Incorporating controls is an essential step in ChIP-seq analysis. The controls are used to account for the background signal, while the remainder of the ChIP-seq signal captures true binding or histone modification. However, a recurrent issue is the existence of different biases in different ChIP-seq experiments. Depending on which controls are used, different aspects of ChIP-seq bias are better or worse accounted for. As a result, peak calling can generate different peaks for the same ChIP-seq experiment. This extension allows for weighted or "smart" controls to model the non-signal effect for a specific ChIP-seq experiment. It first generates the weights per control to model the background distribution per ChIP-seq experiment and is then followed by peak calling.

https://www.biorxiv.org/content/10.1101/582650v1

@taoliu
Copy link
Contributor

taoliu commented Aug 12, 2019

Thanks! I will review this!

@taoliu taoliu self-requested a review August 12, 2019 15:15
@taoliu taoliu self-assigned this Aug 12, 2019
Copy link
Contributor

@taoliu taoliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aawdeh If we plan to merge the new feature of WACS into MACS, could we just add the "-w" or "--control-weights" option to the regular "callpeak" function, instead of creating an almost identical "callpeak_wacs" command? PS: I am specifically discussing merging WACS as a new feature in MACS in this PR page. Also, should I hold this PR until your paper is published in a peer-reviewed journal?

@taoliu taoliu self-requested a review August 12, 2019 20:53
@aawdeh
Copy link
Author

aawdeh commented Aug 14, 2019

@aawdeh If we plan to merge the new feature of WACS into MACS, could we just add the "-w" or "--control-weights" option to the regular "callpeak" function, instead of creating an almost identical "callpeak_wacs" command? PS: I am specifically discussing merging WACS as a new feature in MACS in this PR page. Also, should I hold this PR until your paper is published in a peer-reviewed journal?

@taoliu Thank you for your reply! Yes, that works. Also, I think it should be fine going ahead with this PR. We already have the paper on bioRxiv and will be submitting it soon to a peer-reviewed journal.

@taoliu taoliu added the v2.1.4 v2.1.4 features label Sep 18, 2019
@taoliu taoliu added v2.1.5 and removed v2.1.4 v2.1.4 features labels Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants