Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pinentry-mac: fix building for apple silicon #9564

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

sirn
Copy link
Contributor

@sirn sirn commented Dec 30, 2020

Description

pinentry-mac compiles and runs on Apple Silicon, but require adding arm64 to its build target (GPGTools/pinentry-mac#9).

https://trac.macports.org/ticket/61575

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 11.1 20C69
Xcode 12.3 12C33

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot
Copy link

Notifying maintainers:
@Ionic for port pinentry-mac.

@sirn sirn force-pushed the pinentry-mac-apple-silicon branch from 2881678 to 5fea0ec Compare December 30, 2020 10:20
@neverpanic
Copy link
Member

This lg2m, but formally maintainer approval is required before the maintainer timeout, so let's wait for that.

@kencu
Copy link
Contributor

kencu commented Jan 13, 2021

Trivial change. Two weeks. Will merge.

@kencu kencu merged commit d9631c7 into macports:master Jan 13, 2021
@sirn sirn deleted the pinentry-mac-apple-silicon branch January 14, 2021 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants