Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsoncons: skip a few tests with libstdc++, fix 32-bit #22749

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

barracuda156
Copy link
Contributor

Description

This is a header-only port, but it is set to build tests by default. A number of tests are broken on systems using libstdc++.
Also -Werror breaks 32-bit build.
Fix both issues.

There is no change to the headers, only conditional skipping of broken tests and dropping of -Werror on 32-bit archs.

Remaining tests appear to pass.

Discussion with upstream: danielaparker/jsoncons#488

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6
Xcode 3.2

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@sikmir for port jsoncons.

@macportsbot macportsbot added type: bugfix maintainer: open Affects an openmaintainer port labels Feb 20, 2024
@herbygillot herbygillot merged commit 35d7d87 into macports:master Feb 20, 2024
4 checks passed
@barracuda156 barracuda156 deleted the jsoncons branch February 21, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: bugfix
Development

Successfully merging this pull request may close these issues.

4 participants