hdf5: Revert to normal linker #21341
Merged
+0
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
. Revert workaround for Sonoma/Xcode 15.0. `ld_classic` is no longer needed with HDF5 1.14.3. HDFGroup/hdf5#3571 HDFGroup/hdf5#3581 "Removed "-commons" linking option on Darwin" https://github.com/HDFGroup/hdf5/blob/hdf5_1_14_3/release_docs/RELEASE.txt
|
Notifying maintainers: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revert workaround for Sonoma/Xcode 15.0.
ld_classicis no longer needed with HDF5 1.14.3.HDFGroup/hdf5#3571
HDFGroup/hdf5#3581
'Removed "-commons" linking option on Darwin'
https://github.com/HDFGroup/hdf5/blob/hdf5_1_14_3/release_docs/RELEASE.txt
Type(s)
Tested on
CI only. OS 11, 12, 13 only. X86 only.
Not yet tested on Sonoma, Xcode 15, or ARM.
Verification
Have you
port lint --nitpick?sudo port test?sudo port -vst install?