Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpv: patch youtube-dl hook to fix youtube playback #18038

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

akierig
Copy link
Contributor

@akierig akierig commented Mar 21, 2023

Description

patches mpv's youtube-dl hook to fix playback from youtube that previously threw an error and wouldn't play the audio track of a video.

For example:

> mpv "https://www.youtube.com/watch?v=ZU4JhPgA5EM"
[ytdl_hook] EDL doesn't support fragmentswithout duration with MP4 DASH
EDL specifies no segments.'
EDL parsing failed.
Error in EDL.
EDL: source file 'edl://!mp4_dash,init=%901%https://rr1---sn-gjo-vgqs.googlevideo.com/videoplayback?expire=1679440885&ei=lecZZJbhNoWilu8Pv-SGgAs&ip=<REDACTED>&id=o-AKNjE9PULKVpIu1CNDp1h9kq9u9ZlN1r460RAL3Y03Zi&itag=243&source=youtube&requiressl=yes&mh=r5&mm=31%2C29&mn=sn-gjo-vgqs%2Csn-vgqsrns6&ms=au%2Crdu&mv=m&mvi=1&pl=21&initcwndbps=170000&spc=H3gIhqOK7UbzMuIPu1WGYFXT_-X_-AY&vprv=1&svpuc=1&mime=video%2Fwebm&gir=yes&clen=9342392&dur=2101.732&lmt=1677213445658829&mt=1679418800&fvip=4&keepalive=yes&fexp=24007246&c=ANDROID&txp=5437434&sparams=expire%2Cei%2Cip%2Cid%2Citag%2Csource%2Crequiressl%2Cspc%2Cvprv%2Csvpuc%2Cmime%2Cgir%2Cclen%2Cdur%2Clmt&sig=AOq0QJ8wRQIgTvwEbty7ZAu3BYQHFPjteRY0_mdMiFrVjcLIYc4QffICIQDcsidQQnkA7GVYahKuihdSLodBx0Ktvqf6G92abEyKrw%3D%3D&lsparams=mh%2Cmm%2Cmn%2Cms%2Cmv%2Cmvi%2Cpl%2Cinitcwndbps&lsig=AG3C_xAwRAIgWnMq25Nc0zBOrG6oK4SIEFCOkVAd_gE8LErUEHVdgzICIGC9-Z05cn37vDGQQlI1XGEe0Xa9m7Dpffo5baBkRfMw&range=0-9342392;' has unknown duration.

this patch applies a fix which will eventually be merged into a future mpv release.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 13.2.1 22D68 arm64
Xcode 14.2 14C18

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@i0ntempest for port mpv.
@Ionic for port mpv.

@macportsbot macportsbot added type: bugfix maintainer: open Affects an openmaintainer port labels Mar 21, 2023
@akierig akierig marked this pull request as ready for review March 21, 2023 17:31
@ryandesign
Copy link
Contributor

This patch alters how the program behaves at runtime, so you must increase the port's revision.

@akierig
Copy link
Contributor Author

akierig commented Mar 21, 2023

fixed, thanks @ryandesign

@i0ntempest i0ntempest merged commit b6cb56f into macports:master Mar 22, 2023
@akierig akierig deleted the mpv-ytdl-patch branch March 22, 2023 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: bugfix
Development

Successfully merging this pull request may close these issues.

5 participants