Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retdec-devel: update to 20211107 #12844

Merged
merged 1 commit into from
Nov 10, 2021
Merged

retdec-devel: update to 20211107 #12844

merged 1 commit into from
Nov 10, 2021

Conversation

catap
Copy link
Contributor

@catap catap commented Nov 7, 2021

Description

This changes also enabled support of OpenSSL 3 via openssl PortGroup for retdec-devel.

Anyway, v4.0 is shipped with OpenSSL 1.1.1 and should be build against OpenSSL 1.1 branch.

Fixes: https://trac.macports.org/ticket/63882

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 11.6 20G165 x86_64
Xcode 13.1 13A1030d

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@catap catap force-pushed the retdec branch 3 times, most recently from 4d32a29 to a24e3c2 Compare November 8, 2021 20:30
@catap
Copy link
Contributor Author

catap commented Nov 8, 2021

@mascguy let's wait until CI is over. I think it should green now.

Anyway, I've included requested changes for legacy support. Can I ask you to review and test if you have access to something before Catalina?

Keep in mind that building of retdec requires a few hours.

@mascguy
Copy link
Member

mascguy commented Nov 8, 2021

Oh, one thing to be aware of: The portgroup needs to be fixed too, before your changes will work.

Did you want to include that too?

@catap
Copy link
Contributor Author

catap commented Nov 8, 2021

@mascguy I think migrating this changes to PG is the right things to do. I haven't got anywhere to test PG changes and without a possibility to test it, I can't fix it :)

@mascguy
Copy link
Member

mascguy commented Nov 8, 2021

@mascguy I think migrating this changes to PG is the right things to do. I haven't got anywhere to test PG changes and without a possibility to test it, I can't fix it :)

No worries, go ahead and remove the changes for the PG then. I'll take care of that later, once the PG itself has been fixed.

@catap
Copy link
Contributor Author

catap commented Nov 8, 2021

@mascguy it is done. Let's wait CI to pass it.

@mascguy
Copy link
Member

mascguy commented Nov 9, 2021

It looks like the build for retdec is failing in the 10.14 CI job, with the following link error:

Undefined symbols for architecture x86_64:
  "_EVP_MD_get_size", referenced from:
      retdec::crypto::HashContext::getHash() in libretdec-crypto.a(hash_context.cpp.o)
  "_EVP_PKEY_get_base_id", referenced from:
      retdec::fileformat::Certificate::loadPublicKey() in libretdec-fileformat.a(certificate.cpp.o)
ld: symbol(s) not found for architecture x86_64

Is that expected?

@catap
Copy link
Contributor Author

catap commented Nov 9, 2021

@mascguy nope, this is side effect of new OpenSSL switch. Working on this :)

@catap
Copy link
Contributor Author

catap commented Nov 9, 2021

@mascguy I saw your changes in legacy portgroup. Would you like to incorporate required changes in this port?

@mascguy
Copy link
Member

mascguy commented Nov 9, 2021

@mascguy I saw your changes in legacy portgroup. Would you like to incorporate required changes in this port?

No, I'll take care of that later, once I've had a chance to test on 10.12.

@catap catap force-pushed the retdec branch 4 times, most recently from e1d8a46 to 574ea19 Compare November 9, 2021 17:52
This changes also enabled support of OpenSSL 3 via `openssl` PortGroup
for `retdec-devel`.

Anyway, `v4.0` is shipped with OpenSSL 1.1.1 and should be build against
OpenSSL 1.1 branch.

Fixes: https://trac.macports.org/ticket/63882
@mascguy mascguy merged commit adfad5a into macports:master Nov 10, 2021
@catap catap deleted the retdec branch November 10, 2021 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants