fheroes2: update to 0.9.6

[oleg-derevenetz]

Description

Type(s)

• bugfix
• enhancement
• security fix

Tested on

macOS 11.5.1 20G80 x86_64
Xcode 12.5.1 12E507

Verification

Have you

• followed our Commit Message Guidelines?
• squashed and minimized your commits?
• checked that there aren't other open pull requests for the same change?
• referenced existing tickets on Trac with full URL?
• checked your Portfile with port lint?
• tried existing tests with sudo port test?
• tried a full install with sudo port -vst install?
• tested basic functionality of all binary files?

[reneeotten]

@oleg-derevenetz please don't make whitespace changes mixed in with functional changes as it is hard to see the relevant things that changed.

[oleg-derevenetz]

Hi @reneeotten

@oleg-derevenetz please don't make whitespace changes mixed in with functional changes as it is hard to see the relevant things that changed.

Sorry for this. I peeped this style in another Portfile and I liked it :)

[reneeotten]

Sorry for this. I peeped this style in another Portfile and I liked it :)

no worries! Just to make sure: as long as it conforms to the modeline (i.e., spaces with multiples of 4) it's all fine. If you really want to change the white space you can of course do that, but please do so in a separate commit.

[oleg-derevenetz]

@reneeotten Should I split the squashed commit in this PR in two commits?

[reneeotten]

@reneeotten Should I split the squashed commit in this PR in two commits?

Yes, please!

[reneeotten]

how about white space changes instead of beautify the Portfile? ;)

[reneeotten]

thanks @oleg-derevenetz !

[oleg-derevenetz]

Hi @reneeotten May I ask for an advice for this build on Big Sur for ARM64:

https://build.macports.org/builders/ports-11_arm64-builder/builds/27635

? It seems that cmake wasn't installed to build this Portfile, should I add it to the depends_build? I thought that PortGroup cmake implies this... At least there were no issues with this before, and test builds for this PR didn't catch it...

[oleg-derevenetz]

@reneeotten I'm sorry, nevermind, it looks like I figured it out - #11812.