Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check-ntservice: exclude should be -x, not -E #782

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

kmuto
Copy link
Member

@kmuto kmuto commented Sep 25, 2023

I found a mistype option in README.md of check-ntservice.
-E should be -x. (I checked the code and its behavior)

Copy link
Member

@Arthur1 Arthur1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -43,7 +43,7 @@ command = ["check-ntservice", "--service-name", "SERVICE_NAME"]

```
-s, --service-name= matches if contained in service name
-E, --exclude-service= exclude if contained in service name. This option takes precedence over --service-name
-x, --exclude-service= exclude if contained in service name. This option takes precedence over --service-name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implementation code:

ExcludeService string `long:"exclude-service" short:"x" description:"exclude if contained in service name. This option takes precedence over --service-name."`

@kmuto kmuto merged commit ce29917 into master Sep 25, 2023
@kmuto kmuto deleted the update-check-ntservice-excludeoption branch September 25, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants