Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ntservice #765

Merged
merged 3 commits into from
Sep 8, 2023
Merged

Improve ntservice #765

merged 3 commits into from
Sep 8, 2023

Conversation

tukaelu
Copy link
Contributor

@tukaelu tukaelu commented Aug 22, 2023 •
edited
Loading

The following problems with check-ntservice have been corrected

  • Since the service name determination is a partial match, the intended service may not be checked, so an --exact option to check with a full matched by --service-name has been added.
  • Since all services were checked, the last checked result was returned. This has been corrected to return the result of the first check.
  • When a nonexistent service is specified, it is now set to UNKNOWN.
  • Improved the message to include the service name even if the result is OK.
  • Fixed command description.

When this fix is merged, existing users may be affected as follows.

  • A result that was OK without matching service may become UNKNOWN. This is a correct condition.
  • If multiple services are matched, the result of the first service matched will be returned. This is also the correct state from the perspective of checking for a specific service.

tukaelu added 2 commits August 23, 2023 08:32
@tukaelu
[ntservice] improved checking of Windows services
28ba2a8 
- Added flag to check service names for exact match
- Fixed UNKNOWN alert if service does not exist
- Fixed that the checked service name is displayed in the message when the check result is OK
@tukaelu
[ntservice] fix command description
9bd9af1
@tukaelu tukaelu changed the title [WIP] Improve ntservice Improve ntservice Aug 23, 2023
@tukaelu tukaelu self-assigned this Aug 30, 2023
@yseto yseto merged commit 0f93286 into master Sep 8, 2023
@yseto yseto deleted the improve-ntservice branch September 8, 2023 09:59
@mackerelbot mackerelbot mentioned this pull request Sep 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lufia lufia lufia approved these changes

Assignees

@tukaelu tukaelu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tukaelu @lufia @yseto