Cleanup react routing and update upload page wording #84
Conversation
Signed-off-by: Andrew-Butler <[email protected]>
| render={({match, location}) => | ||
| <IframePage | ||
| title="KFP Experiments" | ||
| path={KFP + "/_/pipeline/?ns=mlx#/experiments" + window.location.pathname.substring(window.location.pathname.indexOf("/experiments")+12)} |
Signed-off-by: Andrew-Butler <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: drewbutlerbb4, yhwang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/reopen |
|
@Tomcli: Failed to re-open PR: state cannot be changed. The pull request cannot be reopened. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@drewbutlerbb4 FYI I need to revert this PR because it broke the details page during login, can you open a new PR for this? Thanks. |
|
you can reproduce the error when you run the quickstart.sh with your images. |
Cleanup react routing to make it more readable, as well as to set up two future PRs around an added 404 page for missed routes and reworking the server routing.
Also,
Resolves: #56