Self-Referential Links Fix for Markdown View #306
Conversation
Resolves machine-learning-exchange#261 Signed-off-by: RRM123 <[email protected]>
ckadner
requested review from
ckadner and
BluThaitanium
and removed request for
Tomcli and
drewbutlerbb4
|
Awesome work! /lgtm |
dashboard/origin-mlx/package.json
Outdated
| "styled-components": "^4.3.1", | ||
| "title-case": "^3.0.3", | ||
| "typescript": "^3.5.2", | ||
| "typescript-logging": "^1.0.0", |
There was a problem hiding this comment.
I assume you added the typescript-logging dependency to help with debugging, but you removed any logging statements from the code in your PR. Did the logging not work well or did you find it was not necessary given other means of debugging?
There was a problem hiding this comment.
I updated the package.json file to remove the typescript-logging dependency.
I also regenerated the package-lock.json as the one you generated did not look right. Are you using an old version of NodeJS/npm?
Signed-off-by: Christian Kadner <[email protected]>
And its dependencies: * "error-stack-parser" * "stack-generator" * "stackframe" * "stacktrace-gps" * "stacktrace-gps" * "source-map" * "stacktrace-js" Signed-off-by: Christian Kadner <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckadner, RRM123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ge#306) * Self-Referential Links Fix for Markdown View Resolves machine-learning-exchange#261 Signed-off-by: RRM123 <[email protected]> * Update package-lock.json Signed-off-by: Christian Kadner <[email protected]> * Remove unused package "typescript-logging" And its dependencies: * "error-stack-parser" * "stack-generator" * "stackframe" * "stacktrace-gps" * "stacktrace-gps" * "source-map" * "stacktrace-js" Signed-off-by: Christian Kadner <[email protected]> Co-authored-by: Christian Kadner <[email protected]> Signed-off-by: Krishna Kumar <[email protected]>
Upgraded / Added the following dependencies to
dashboard/origin-mlx/package.json:react-markdown: ^4.0.8 --> ^8.0.0remark-gfm: ^2.0.0 --> ^3.0.0rehype-slug: ^5.0.1Changes were made to
OperatorDetail.tsx,MarkdownViewer.tsx, andMetaCard.tsxtoaccommodate the new version of
react-markdownandrehype-slug.Resolves #261
/assign @ckadner