Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incompatible Python packages in mlx-api build #302

Merged

Conversation

ckadner
Copy link
Member

@ckadner ckadner commented Feb 18, 2022

Pinning/downgrading the following dependencies:

* elyra-server<3.4.0            # elyra-server>=3.4.0 requires minio>7.0.0 which breaks mlx-api code
* python-lsp-server[all]<1.3.0  # from elyra-server, 1.3.0 requires autopep8>=1.6.0 but elyra-server==3.3.0 requires autopep8<1.5.6
* black==21.12b0                # from elyra-server, 22.1.0 requires click>=8.0.0 which breaks kfp 1.7.1 and Flask 1.1.4
* Flask>=1.1.4,<2.0.0           # Flask>2.0.0 requires Werkzeug>=2.0, but connexion[swagger-ui]==2.9.0 requires werkzeug<2.0,>=1.0

Resolves #299

Pinning/downgrading the following dependencies:
* elyra-server<3.4.0            # elyra-server>=3.4.0 requires minio>7.0.0 which breaks mlx-api code
* python-lsp-server[all]<1.3.0  # from elyra-server, 1.3.0 requires autopep8>=1.6.0 but elyra-server==3.3.0 requires autopep8<1.5.6
* black==21.12b0                # from elyra-server, 22.1.0 requires click>=8.0.0 which breaks kfp 1.7.1 and Flask 1.1.4
* Flask>=1.1.4,<2.0.0           #  Flask>2.0.0 requires Werkzeug>=2.0, but connexion[swagger-ui]==2.9.0 requires werkzeug<2.0,>=1.0

Resolves machine-learning-exchange#299

Signed-off-by: Christian Kadner <[email protected]>
@mlx-bot
Copy link
Collaborator

mlx-bot commented Feb 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ckadner ckadner added API Swagger API bug Something isn't working CI/CD dependencies Pull requests that update a dependency file labels Feb 18, 2022
@ckadner
Copy link
Member Author

ckadner commented Feb 19, 2022

@Tomcli @yhwang -- when you get a minute, could you /lgtm this PR? We need to get our API build fixed.

@Tomcli
Copy link
Member

Tomcli commented Feb 19, 2022

/lgtm

@ckadner
Copy link
Member Author

ckadner commented Feb 19, 2022

I tested this in a new mlx-api image ckadner/mlx-api:2022-02-18 on my local KIND deployment, catalog operations, code gen, running at least one of each asset pipelines

@mlx-bot mlx-bot merged commit 9fd2612 into machine-learning-exchange:main Feb 19, 2022
krishnakumar27 pushed a commit to krishnakumar27/mlx that referenced this pull request Mar 30, 2022
…xchange#302)

Pinning/downgrading the following dependencies:
* elyra-server<3.4.0            # elyra-server>=3.4.0 requires minio>7.0.0 which breaks mlx-api code
* python-lsp-server[all]<1.3.0  # from elyra-server, 1.3.0 requires autopep8>=1.6.0 but elyra-server==3.3.0 requires autopep8<1.5.6
* black==21.12b0                # from elyra-server, 22.1.0 requires click>=8.0.0 which breaks kfp 1.7.1 and Flask 1.1.4
* Flask>=1.1.4,<2.0.0           #  Flask>2.0.0 requires Werkzeug>=2.0, but connexion[swagger-ui]==2.9.0 requires werkzeug<2.0,>=1.0

Resolves machine-learning-exchange#299

Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Krishna Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Swagger API approved bug Something isn't working CI/CD dependencies Pull requests that update a dependency file lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MLX API build is broken
3 participants