Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace /os with /mlx #297

Merged
merged 4 commits into from
Feb 16, 2022
Merged

Replace /os with /mlx #297

merged 4 commits into from
Feb 16, 2022

Conversation

rafvasq
Copy link
Contributor

@rafvasq rafvasq commented Feb 14, 2022

Resolves #295

Replace /os with /mlx
3d764ab 
Signed-off-by: Rafael Vasquez <[email protected]>
ckadner
ckadner requested changes Feb 14, 2022
View reviewed changes
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rafvasq -- Lets use this opportunity to also make the documentation here a little more coherent

README.md Outdated Show resolved Hide resolved
Rafael Vasquez added 2 commits February 16, 2022 11:23
Update documentation
56110e4 
Signed-off-by: Rafael Vasquez <[email protected]>
Update default path
69bca29 
Signed-off-by: Rafael Vasquez <[email protected]>
ckadner
ckadner requested changes Feb 16, 2022
View reviewed changes
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks Rafael. I only a small nitpick left :-)

README.md Outdated

To find the public ip of a node of your cluster
**If you deployed on a Kubernetes cluster, run the following and look for the ExternalIP column to find the public IP of a node.**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only Kubernetes should be bold here

README.md Outdated Show resolved Hide resolved
Update documentation
2ce8183 
Signed-off-by: Rafael Vasquez <[email protected]>
ckadner
ckadner approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thank you @rafvasq

@mlx-bot
Copy link
Collaborator

mlx-bot commented Feb 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, rafvasq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ckadner ckadner merged commit 2538fb1 into machine-learning-exchange:main Feb 16, 2022
@rafvasq rafvasq deleted the doc-ui-path branch February 16, 2022 20:12
@ckadner ckadner added the Jump-Start Work items for Jump-Start participants label Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckadner ckadner ckadner approved these changes

@Tomcli Tomcli Awaiting requested review from Tomcli

Assignees
No one assigned
Labels
approved Jump-Start Work items for Jump-Start participants
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accessing MLX UI - Default Page
3 participants
@rafvasq @mlx-bot @ckadner