Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed Dashboard Dependency on Catalog Service #275

Merged
merged 2 commits into from
Dec 3, 2021
Merged

Removed Dashboard Dependency on Catalog Service #275

merged 2 commits into from
Dec 3, 2021

Conversation

JAulet
Copy link
Contributor

@JAulet JAulet commented Dec 1, 2021 •
edited
Loading

Description of changes:

  • Edited docker-compose.yaml to remove catalog
    dependency from dashboard service
  • Edited api/README.md to correct docker compose
    instructions

Modified command to add dashboard service.

docker compose --project-name  no_api   up   minio miniosetup mysql mlx-ui dashboard

Console Output:

no_api-mlx-ui-1      | [HPM] Proxy created: /  ->  http://mlx-api
no_api-mlx-ui-1      | Server listening at http://localhost:3000
no_api-dashboard-1   |
no_api-dashboard-1   | ================================================
no_api-dashboard-1   |  Open the MLX Dashboard at http://localhost:80/
no_api-dashboard-1   | ================================================

Resolves #274

@ckadner Please Review

@JAulet
Removed Dashboard Dependency on Catalog Service
b8e09d1 
* Edited docker-compose.yaml to remove catalog
  dependency from dashboard service
* Edited api/README.md to correct docker compose
  instructions

Resolves machine-learning-exchange#274

Signed-off-by: JAulet <[email protected]>
@JAulet
Copy link
Contributor Author

JAulet commented Dec 1, 2021

@girigsrini Could you try this out?

@ckadner ckadner added the RCOS Potential work items for RCOS student interns label Dec 2, 2021
@ckadner ckadner requested review from GiriSrini and removed request for drewbutlerbb4 December 2, 2021 00:07
@ckadner ckadner requested a review from vedantgannu December 2, 2021 02:25
@ckadner
Copy link
Member

ckadner commented Dec 2, 2021

@vedantgannu -- if you get a chance, please give this one a quick review as well. Thanks.

@ckadner
Remove catalog dependency from dashboar service
4745664 
We don't actually need that comment and the only
actual hard dependency is the mlx-ui

Signed-off-by: Christian Kadner <[email protected]>
ckadner
ckadner approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mlx-bot mlx-bot added the lgtm label Dec 3, 2021
@mlx-bot
Copy link
Collaborator

mlx-bot commented Dec 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, JAulet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ckadner ckadner merged commit 797e7a1 into machine-learning-exchange:main Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckadner ckadner ckadner approved these changes

@GiriSrini GiriSrini Awaiting requested review from GiriSrini

@vedantgannu vedantgannu Awaiting requested review from vedantgannu

Assignees

@ckadner ckadner

@GiriSrini GiriSrini

@vedantgannu vedantgannu

Labels
approved lgtm RCOS Potential work items for RCOS student interns
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API Development with Docker Compose Shows Wrong UI Port
5 participants
@JAulet @ckadner @mlx-bot @GiriSrini @vedantgannu