Added buttons that can delete assets #267
Conversation
Signed-off-by: Zachary-Fernandes <[email protected]>
I initially created the buttons for each asset. Prasant helped me with API requests and reloading the page. Co-authored-by: Zachary-Fernandes <[email protected]> Co-authored-by: Prasantacharya <[email protected]>
I initially created the buttons for each asset. Prasant helped me with API requests and reloading the page. Co-authored-by: Zachary-Fernandes <[email protected]> Co-authored-by: Prasantacharya <[email protected]> Signed-off-by: Zachary-Fernandes <[email protected]>
…to deleting-assets
|
Thank you @Zachary-Fernandes -- could you add a screenshot as well? |
|
Sure thing, I can demonstrate it by deleting Project CodeNet Language Classifier. Here it is before deleting: Here it is after deleting: |
| window.location.reload(); | ||
| }} | ||
| > | ||
| <span className="delete-button-text">DELETE</span> |
There was a problem hiding this comment.
I would make it Title-case: Delete, and update the className="delete-button-text" to a color and font that matches the rest of this page
| @@ -66,6 +66,7 @@ function MetaAllPage(props: MetaAllPageProps) { | |||
| { id: 'feat', label: 'Featured', numeric: false }, | |||
| { id: 'pub', label: 'Published', numeric: false }, | |||
| { id: 'cat', label: tagName, numeric: false }, | |||
| { id: 'del', label: 'Delete Asset', numeric: false }, | |||
Signed-off-by: Zachary-Fernandes <[email protected]>
…to deleting-assets
|
@Zachary-Fernandes does this screenshot reflect your latest changes?
|
|
Yes. It originally was red with a minus sign because I could not figure out how to spawn lowercase text, but after making a new style in Models.css, I figured out how to do this. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckadner, Zachary-Fernandes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The UI now includes buttons when accessing all the assets. These
buttons delete the assets they are associated with when they are
clicked.
Resolves #157
@ckadner