Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modelmesh support #242

Merged
merged 3 commits into from
Oct 29, 2021
Merged

Add modelmesh support #242

merged 3 commits into from
Oct 29, 2021

Conversation

drewbutlerbb4
Copy link
Contributor

Signed-off-by: Andrew-Butler [email protected]

Rework the inference services asset to work with model-mesh predictors. Includes accessing the predictors with the kubernetes Python sdk, adding cluster role and role binding, and parsing the predictor yaml, and displaying predictor info in UI.

Signed-off-by: Andrew-Butler <[email protected]>
@mlx-bot
Copy link
Collaborator

mlx-bot commented Oct 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: drewbutlerbb4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@drewbutlerbb4
Copy link
Contributor Author

@Tomcli I have a cluster-role and cluster-rolebinding that need to applied on installation. Could you advise on how to get that working?

@Tomcli
Copy link
Member

Tomcli commented Oct 19, 2021

@drewbutlerbb4 do you have the command/yaml for the new cluster-role? I can convert them into something kustomize can understand and deploy it as part of the deployment.

@Tomcli
Copy link
Member

Tomcli commented Oct 19, 2021

modelmesh-rolebinding.yaml Outdated Show resolved Hide resolved
modelmesh-role.yaml Outdated Show resolved Hide resolved
@drewbutlerbb4
Copy link
Contributor Author

Thanks @Tomcli, I have updated accordingly

Signed-off-by: Andrew-Butler <[email protected]>
@drewbutlerbb4
Copy link
Contributor Author

Okay @Tomcli, I have added that below. Thanks!

@Tomcli
Copy link
Member

Tomcli commented Oct 29, 2021

/lgtm

@mlx-bot mlx-bot added the lgtm label Oct 29, 2021
@Tomcli Tomcli merged commit 269f34a into machine-learning-exchange:main Oct 29, 2021
@ckadner ckadner linked an issue Feb 2, 2022 that may be closed by this pull request
3 tasks
@ckadner ckadner mentioned this pull request Feb 2, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ModelMesh support
3 participants