Small navigation improvements #238
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Prasantacharya The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thank you @Prasantacharya -- this is better :-) Do you think it could be even more improved by vertically centering the speech bubble icon?
|
|
@ckadner ive shifted down the icons a bit. Altho when i built the site to test, I didnt have the white pullet points, which I assume is what I would be centering with? |
|
The speech bubble icon is aligned nicely now, but now the bullet point is sitting too low.
|
|
@Prasantacharya -- could you sign your commits to get the DCO check to pass? |
…e it is pushed to the top via guard height Signed-off-by: Prasantacharya <[email protected]>
Signed-off-by: Prasantacharya <[email protected]>
… links Signed-off-by: Prasantacharya <[email protected]>
Signed-off-by: Prasantacharya <[email protected]>
Signed-off-by: Prasantacharya <[email protected]>
Signed-off-by: Prasantacharya <[email protected]>
Prasantacharya
force-pushed
the
issue-198
branch
from
8c9da27 to
e68e624
Compare
|
@Prasantacharya -- did you ever get a chance to find out why the bullet point shows up out of line? I screenshoted that on Firefox |
There was a problem hiding this comment.
@Prasantacharya -- if you can find out how to vertically align (center) the icon and text with the bullet point that would be great.
|
|
Yeah, did this require further code changes? Did you push those to this PR? |
| @@ -13,6 +13,9 @@ Allows upload, registration, execution, and deployment of: | |||
| - Datasets | |||
| - Notebooks | |||
|
|
|||
| For more details about the project please follow this [announcement blog post](https://lfaidata.foundation/blog/2021/09/28/machine-learning-exchange-mlx/). | |||
There was a problem hiding this comment.
This change here seems unrelated. Could you rebase your PR or merge in the latest changes from main?
Signed-off-by: Prasantacharya <[email protected]>
Resolves #198
For non-logged in users, the "join the conversation" button sits at the bottom, but for admins, it is in its usual spot
Also the text now aligns with the paragraph instead of the icon