Update machine-drivers/machine to docker/machine #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also changes the description of the amazonec2-ssh-user flag to be more consistent with other drivers. Signed-off-by: Timothy Jones <[email protected]>
Signed-off-by: Jason-ZW <[email protected]>
Signed-off-by: Gerard Braad <[email protected]>
Add the --google-service-account flag to create VMs that are not provisioned with the default service account. Signed-off-by: Peter Schultz <[email protected]>
Signed-off-by: xinau <[email protected]>
It would be set by the request returned by http.NewRequest. Signed-off-by: Mohit Agarwal <[email protected]>
Signed-off-by: Albin Gustavsson <[email protected]>
Add AWS region eu-north-1
drivers/softlayer: don't set the request method again
drivers/openstack: added flag openstack-metadata
drivers/google: Add support for non-default service account
Allow localized names for Virtual Switch
Add nonempty flag
Add ssh-port flag to the amazonec2 driver
Signed-off-by: Joffrey F <[email protected]>
Remove shin- from active maintainers list
Signed-off-by: David Gageot <[email protected]>
Remove myself from the list of maintainers
…ion doesn't exist anymore (see 60613ca) Signed-off-by: Ulysses Souza <[email protected]>
Removing "dgageot" handle form "Core maintainers"
VMX is in FeatureNames, but SVM is in ExtraFeatureNames This meant that detection *always* failed for SVM (AMD) Thanks to user @hilbertxia Signed-off-by: Anders F Björklund <[email protected]>
Signed-off-by: Serhii R <[email protected]>
Fix broken IsVTXDisabled detection on AMD CPU
set storage driver to overlay2 for archlinux
anjannath
pushed a commit
to anjannath/machine
that referenced
this pull request
Aug 27, 2019
Currently hyperv and libvirt have this as a driver specific field, but this was forgotten in hyperkit. This will be needed to be able to know which version of CRC is running from a ~/.crc/machines/crc directory. We limit ourselves to a "BundleName" rather than a "BundePath" as we cannot rely on files outside of ~/.crc to be untouched by the user (ie not moved/removed). Since bundles are extracted to ~/.crc/cache/$BundleName, this the name is going to be enough to find back the bundle content. crc-org#19
anjannath
pushed a commit
to anjannath/machine
that referenced
this pull request
Aug 27, 2019
Issue machine-drivers#19: Add bundle name to base driver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the two fixes, added downstream:
This means that there are no more differences...
After this, we could force-push
master(drop rebases) ?github.com/docker/machine
a555e4f
Same idea as #15 (from March), but now with updates.