Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit WARC header/content capture to current tab only #7

Open
machawk1 opened this issue May 22, 2013 · 3 comments
Open

Limit WARC header/content capture to current tab only #7

machawk1 opened this issue May 22, 2013 · 3 comments
Assignees
@machawk1
Labels
bug
Milestone
1.0 Release

Comments

@machawk1
Copy link
Owner

Currently, asynchronous requests from other tabs pollute the WARC if they occur during the WARC creation process.
@machawk1
Copy link
Owner Author

This might be fixed by limiting the capture to the current tab in the response and request capture filters but requires a bit more testing, which should be easy enough by keeping some other site that extensively uses Ajax open in another tab.

machawk1 added a commit that referenced this issue Jul 8, 2013
@machawk1
Added restrictions to limit header captures only to current tab for #7.…
2bd588e 
… Not 100% this is working compeltely just yet.
@machawk1 machawk1 mentioned this issue Oct 31, 2013
Closed
This was referenced Jul 25, 2014
Open
Open
@machawk1 machawk1 mentioned this issue Aug 11, 2014
Closed
@machawk1
Copy link
Owner Author

For testing, throw this page ( http://warcreate.com/tests/bug7.html ) up in a tab, new tab, enable WARCreate with a simple HTML page, and note the noise included in the WARC.

@machawk1
Copy link
Owner Author

Is this the right functionality or should it be "all of the tabs the user visited with WARCreate enabled."

machawk1 added a commit that referenced this issue Aug 13, 2014
@machawk1
Added code for tab id storage, related to eventually fixing #7
76e6da1
@machawk1 machawk1 self-assigned this Dec 9, 2014
@machawk1 machawk1 mentioned this issue Jul 6, 2017
Open
@machawk1 machawk1 pinned this issue Jan 7, 2020
@machawk1 machawk1 mentioned this issue Jan 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@machawk1 machawk1

Labels
bug
Projects
None yet
Milestone
1.0 Release
Development

No branches or pull requests
1 participant
@machawk1