Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapting code to use manifest v3 #117

Open
machawk1 opened this issue Nov 12, 2019 · 6 comments
Open

Adapting code to use manifest v3 #117

machawk1 opened this issue Nov 12, 2019 · 6 comments

Comments

@machawk1
Copy link
Owner

https://www.bleepingcomputer.com/news/software/google-begins-testing-extension-manifest-v3-in-chrome-canary/

It will have significant changes to the webRequest API, which WARCreate extensively uses.

@machawk1
Copy link
Owner Author

machawk1 commented Dec 9, 2020

Now available in Chrome 88 beta per https://blog.chromium.org/2020/12/manifest-v3-now-available-on-m88-beta.html

Note the deprecated of background pages in favor of service workers.

machawk1 added a commit that referenced this issue Dec 20, 2020
@machawk1
Copy link
Owner Author

The beta still does not read all attributes of Manifest v3. Use the Dev channel build for testing.

@machawk1
Copy link
Owner Author

@machawk1
Copy link
Owner Author

chrome.tabs.getSelected() has been deprecated per https://developer.chrome.com/docs/extensions/mv3/intro/mv3-migration/ , so the code needs to be adapted.

@machawk1
Copy link
Owner Author

machawk1 commented Dec 23, 2020

The usage of chrome.tabs.connect in serviceWorker.js, e.g.,

  let port = chrome.tabs.connect(tab.id, { name: 'getImageData' }) // create a persistent connection
  port.postMessage({ url: tab.url, method: 'getImageData' })

causes an error, observable in the popup's console, that says,

Error handling response: TypeError: Error in invocation of tabs.connect(integer tabId, optional object connectInfo): No matching signature.

In the "Long-Lived Connections" section of https://developer.chrome.com/docs/extensions/mv2/messaging/ , the link to "tabs.connect" is a 404. Attempting to view the signature says, "VM311:1 function connect() { [native code] }".

@machawk1
Copy link
Owner Author

https://developer.chrome.com/docs/extensions/mv3/mv2-sunset/
To be deprecated for existing extensions in January 2023

@machawk1 machawk1 pinned this issue May 31, 2022
@machawk1 machawk1 changed the title Begin testing and adapting code to use manifest v3 Adapting code to use manifest v3 Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant