Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to using StreamSaver from FileSaver #105

Open
machawk1 opened this issue Apr 14, 2018 · 3 comments
Open

Migrate to using StreamSaver from FileSaver #105

machawk1 opened this issue Apr 14, 2018 · 3 comments

Comments

@machawk1
Copy link
Owner

There seems to be quite a few advantages (e.g., higher file size limit) but support is limited to Chrome and Opera at the moment, which is not an issue.

https://github.com/jimmywarting/StreamSaver.js

@machawk1 machawk1 added this to the 1.X Release milestone Apr 14, 2018
machawk1 added a commit that referenced this issue Apr 14, 2018
@machawk1
Copy link
Owner Author

I poked around the module in the issue-105 branch. Even with the example code in-place, no file appears to be written from the extension context. Perhaps there is an issue with ServiceWorker support as initiated from extensions.

@N0taN3rd
Copy link
Collaborator

@machawk1
You mighy have better luck using https://github.com/feross/buffer

It's nodes buffer module but for the browser.

I found it useful for stuffing content into blobs.

@machawk1
Copy link
Owner Author

@N0taN3rd Thanks for the recommendation. Getting the data in Blob form is not an issue -- that's working fine for FileSaver.

I was opting for StreamSaver due to its ability to write larger files to disk (outside of the sandbox) compared to FileSaver and not necessarily its streaming capability.

I do not see anything in @feross's buffer package that would allow this but perhaps it is capable but wrapped up in the abstraction. Can you provide more insight on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants