Adapt risk summary to both entity flyouts #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machadoum
reviewed
Jan 2, 2024
x-pack/plugins/security_solution/public/flyout/entity_details/host_right/content.tsx
Outdated
Show resolved
Hide resolved
machadoum
reviewed
Jan 2, 2024
| }, [userRiskData]); | ||
| const entityData = (() => { | ||
| if (!riskData) return; | ||
| if (entity === RiskScoreEntity.user) return (riskData as UserRiskScore).user; |
There was a problem hiding this comment.
NIT
You could create a User-Defined Type Guard like here:
function isUserEntity(entity: UserRiskScore | HostRiskScore): entity is UserRiskScore {
return (entity as UserRiskScore).user !== undefined;
}
There was a problem hiding this comment.
Yeah, I wasn't too happy about this
I can extract to a function with a type predicate rather than the IIFE, but it's still gonna be brittle 🤔
And its worse here because it's not just one value, the entityData type depends on the entity prop type, so our type predicate would depend on other, additional types on top of the type it is narrowing.
I'm not sure if there's a better solution.
I actually originally just copied and duplicated the component before making it generic, but I also don't think that's acceptable 😅
machadoum
approved these changes
Jan 2, 2024
tiansivive
force-pushed
the
siem-ea-8084-risk-summary
branch
from
7ce37ee to
9b10b2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted Risk Summary to both flyouts