Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phantomas V2 - the final merge into the main branch #753

Merged
merged 275 commits into from
Aug 7, 2020
Merged

Phantomas V2 - the final merge into the main branch #753

merged 275 commits into from
Aug 7, 2020

Conversation

macbre
Copy link
Owner

@macbre macbre commented Jul 28, 2020 •
edited
Loading

See #707

/cc @gmetais

TODO

  • publish alpha versions periodically to npm from this branch:
npm version v2.0.0-alpha1 prerelease
npm publish --tag next
  • try to fix remaining, size-related tests that fail when run outside of the container using GitHub Actions

macbre added 30 commits December 30, 2018 13:55
@macbre
Set up Travis for Chrome stable
f7dd1f5
@macbre
Improve tests code
ab1de07
@macbre
Browser: handle PHANTOMAS_CHROMIUM_EXECUTABLE env variable
3e5b9e6
@macbre
loader: be compatible with Node.js v8
84b4473
@macbre
requestsMonitor: all tests now pass
81bc6c9
@macbre
phantomas object will probably go away
4a2fdc0
@macbre
vows: v0.8.2
afbab88
@macbre
loader: linting + JSdoc
4da2f27
@macbre
examples: show offenders
004c28f
@macbre
Fix test/modules/requestsStats-test.js
a5eba26
@macbre
test/results-test.js: offenders can be objects too
82168ef
@macbre
requestsMonitor: handle base64-encoded assets
0931e88
@macbre
Use http-serve (with gzip compression)
c3fb168
@macbre
assetsTypes: more tests do pass now
048ea8d
@macbre
Inject core/scope.js into the browser
7b23a46
@macbre
Browser: handle connection errors within a promise
971cbe5
@macbre
requestsMonitor: lowercase response headers
081e8be
@macbre
Resolve "Protocol error (Runtime.callFunctionOn): Target closed."
23f889f 
Call page.evaludate() when the page is fully loaded (after page.goto promise is resolved), but before page.close() is called.
@macbre
Inject phantomas page scope JS code via page.evaluateOnNewDocument wh…
3bd0460 
…en "init" event is fired
@macbre
domQueries: move page scope code into a separate file and run it via …
79e29fb 
…phantomas.injectJs()
@macbre
index.js: expose the function that will pass events from page scope c…
1466493 
…ode into Node.js layer

@see https://github.com/GoogleChrome/puppeteer/blob/v1.11.0/docs/api.md#pageexposefunctionname-puppeteerfunction
@macbre
Use __phantomas_emit to send messages from page scope code to Node.js…
aa31f8c 
… layer

Fire "scopeMessage" events.

  /dom-operations.html
    ✓ should be generated
    ✓ should have "requests" metric properly set
    ✓ should have "cssCount" metric properly set
    ✓ should have "cssSize" metric properly set
    ✓ should have "jsCount" metric properly set
    ✓ should have "jsSize" metric properly set
    ✓ should have "domains" metric properly set
    ✓ should have "DOMqueries" metric properly set
    ✓ should have "DOMqueriesById" metric properly set
    ✓ should have "DOMqueriesByClassName" metric properly set
    ✓ should have "DOMqueriesByTagName" metric properly set
    ✓ should have "DOMqueriesByQuerySelectorAll" metric properly set
    ✓ should have "DOMinserts" metric properly set
    ✓ should have "DOMqueriesDuplicated" metric properly set
    ✓ should have "DOMqueriesAvoidable" metric properly set
    ✓ should have "DOMqueriesWithoutResults" metric properly set
@macbre
setMetric: pass calls from page scope code + default to zero when no …
a140879 
…value is provided
@macbre
browser: pass pageerror event from Puppeteer to phantomas + test case…
34b4953 
… for jserrors module
@macbre
Remove old core/ files that were running in PhantomJS scope
c4a8298
@macbre
examples: add a short README
9baa092
@macbre
scopeMessage: handle log and addOffender called from page scope code
f3443f7
@macbre
A separate log label for phantomas.log calls from page scope code
d42d891
@macbre
domMutations: module works again :)
3163a6f 
  /dom-operations.html
    ✓ should be generated
    ✓ should have "DOMmutationsInserts" metric properly set
@macbre
domComplexity: start a refactoring
6ea4cc3 
  /dom-id.html
    ✓ should be generated
    ✓ should have "DOMidDuplicated" metric properly set
macbre and others added 12 commits July 28, 2020 18:31
Merge remote-tracking branch 'origin/devel' into phantomas-v2
dc50ef1
@dependabot
build(deps): bump async from 2.6.3 to 3.2.0
f969faa 
Bumps [async](https://github.com/caolan/async) from 2.6.3 to 3.2.0.
- [Release notes](https://github.com/caolan/async/releases)
- [Changelog](https://github.com/caolan/async/blob/master/CHANGELOG.md)
- [Commits](caolan/async@v2.6.3...v3.2.0)

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
build(deps): bump csv-string from 3.2.0 to 4.0.1
8d013bb 
Bumps [csv-string](https://github.com/Inist-CNRS/node-csv-string) from 3.2.0 to 4.0.1.
- [Release notes](https://github.com/Inist-CNRS/node-csv-string/releases)
- [Commits](Inist-CNRS/node-csv-string@v3.2.0...v4.0.1)

Signed-off-by: dependabot[bot] <[email protected]>
@macbre
Merge pull request #754 from macbre/dependabot/npm_and_yarn/async-3.2.0
46ca303 
build(deps): bump async from 2.6.3 to 3.2.0
@macbre
Merge branch 'phantomas-v2' into dependabot/npm_and_yarn/csv-string-4…
c8ff53c 
….0.1
@macbre
Merge pull request #755 from macbre/dependabot/npm_and_yarn/csv-strin…
7251b64 
…g-4.0.1

build(deps): bump csv-string from 3.2.0 to 4.0.1
@macbre
Add inch-ci.org badge
e9d2b2c
@macbre
package.json - update project description
60814df
@dependabot
build(deps-dev): bump eslint from 7.5.0 to 7.6.0
356bb0a 
Bumps [eslint](https://github.com/eslint/eslint) from 7.5.0 to 7.6.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](eslint/eslint@v7.5.0...v7.6.0)

Signed-off-by: dependabot[bot] <[email protected]>
@macbre
Merge pull request #756 from macbre/dependabot/npm_and_yarn/eslint-7.6.0
ce7606c 
build(deps-dev): bump eslint from 7.5.0 to 7.6.0
@macbre
Run tests using Node.js 12.x too
03fb4f3
@macbre
Merge pull request #757 from macbre/test-nodejs-12x
8b367b9 
Run tests using Node.js 12.x too
@macbre macbre marked this pull request as ready for review August 6, 2020 22:37
@macbre
Copy link
Owner Author

macbre commented Aug 6, 2020

@gmetais - https://www.npmjs.com/package/phantomas/v/2.0.0-alpha1

dependabot bot and others added 7 commits August 7, 2020 05:02
@dependabot
build(deps): bump analyze-css from 0.12.10 to 0.12.11
1212311 
Bumps [analyze-css](https://github.com/macbre/analyze-css) from 0.12.10 to 0.12.11.
- [Release notes](https://github.com/macbre/analyze-css/releases)
- [Commits](macbre/analyze-css@v0.12.10...v0.12.11)

Signed-off-by: dependabot[bot] <[email protected]>
@macbre
Merge pull request #760 from macbre/dependabot/npm_and_yarn/analyze-c…
8e6b5df 
…ss-0.12.11

build(deps): bump analyze-css from 0.12.10 to 0.12.11
@macbre
.npmignore: make npm package a bit smaller
8216290 
Resolves #762

Before:

$ npm publish --dry-run 2>&1 | egrep 'size|files'

npm notice package size:  392.1 kB
npm notice unpacked size: 781.0 kB
npm notice total files:   164

After:

npm notice package size:  67.1 kB
npm notice unpacked size: 258.3 kB
npm notice total files:   86
@macbre
Bump minimum Node.js version to 12.x
936ccca
@macbre
.eslintrc.yml: make settings more explicit
6a736f9
@macbre
Fixing "No usable sandbox"
a294105
@macbre
Remove mentions of PhantomJS
42c3637
@macbre macbre merged commit e3453b6 into devel Aug 7, 2020
@macbre macbre mentioned this pull request Aug 7, 2020
Closed
@macbre macbre deleted the phantomas-v2 branch September 1, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0 - headless Chromium
Development

Successfully merging this pull request may close these issues.

Switch from PhantomJS to Chrome's headless mode
1 participant
@macbre