Refactor Phantomas to run using headless Chrome #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/test/webroot/static/mdn.png -- 22.46kb -> 19.91kb (11.37%)
Found 11 options covered by integration-spec.yaml: --allow-domain, --analyze-css, --cookie, --no-externals, --page-source, --post-load-delay, --spy-eval, --timeout, --wait-for-event, --wait-for-network-idle, --wait-for-selector
image-scaling.html (with --screenshot)
✓ should be generated
✓ PNG file should be saved
…before analyzing CSS and closing the browser session
Extensions TODO
|
✓ OK » 402 honored (27.456s)
It respects Promise pattern by callin "await" internally (for listeners that return a Promise).
✓ OK » 416 honored (29.654s)
/https-fonts.html
✓ should be generated
✓ should have "requests" metric properly set
✓ should have "httpsRequests" metric properly set
✓ should have "webfontCount" metric properly set
✓ should have "domains" offender(s) properly set
✓ OK » 421 honored (35.782s)
Metrics tests coverage: from 54.65% to 55.81%
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Encoding#Directives Add an assert for "assetsNotGzipped" metric. Metrics tests coverage: from 55.81% to 56.40%
/assets.html
✓ should be generated
✓ should have "assetsWithQueryString" offender(s) properly set
✓ should have "smallImages" offender(s) properly set
✓ should have "smallCssFiles" offender(s) properly set
Metrics tests coverage: 58.14%
httpbin's /basic-auth
✓ should reject a promise
httpbin's /basic-auth (with --auth-user and --auth-pass)
✓ should be generated
✓ should have "requests" metric properly set
✓ should have "httpsRequests" offender(s) properly set
✓ OK » 432 honored (47.745s)
macbre
added
internals
Chrome-headless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #707
Tests do fail as the code is refactored.