Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump puppeteer to v22.10.0 [HeadlessChrome/125.0.0.0] #1369

Merged
merged 7 commits into from
May 24, 2024
Merged

bump puppeteer to v22.10.0 [HeadlessChrome/125.0.0.0] #1369

merged 7 commits into from
May 24, 2024

Conversation

macbre
Copy link
Owner

@macbre macbre commented May 24, 2024

@macbre macbre self-assigned this May 24, 2024
@macbre macbre enabled auto-merge May 24, 2024 11:32
@socket-security Socket Security
Copy link

socket-security bot commented May 24, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] Transitive: environment, filesystem, network, shell, unsafe +108 20.5 MB

🚮 Removed packages: npm/[email protected]

View full report↗︎

@macbre
Copy link
Owner Author

macbre commented May 24, 2024 

/home/runner/work/phantomas/phantomas/lib/browser.js:208
      meta.response.encodedDataLength; /* "or" fallback for 404 response */
                    ^

TypeError: Cannot read properties of undefined (reading 'encodedDataLength')
    at Object.onRequestLoaded (/home/runner/work/phantomas/phantomas/lib/browser.js:208:21)

@macbre macbre changed the title bump puppeteer to v22.10.0 bump puppeteer to v22.10.0 [HeadlessChrome/125.0.0.0] May 24, 2024
@macbre macbre force-pushed the puppeteer/22.10.0 branch from 32cb98c to 11e2048 Compare May 24, 2024 11:56
macbre
macbre commented May 24, 2024
View reviewed changes
lib/index.js
@@ -98,7 +101,9 @@ function phantomas(url, opts) {
suffix = "}";

const preloadFile =
prefix + require("fs").readFileSync(script, "utf8") + suffix;
prefix +
(await require("fs/promises").readFile(script, "utf8")) +
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be more async :-)

macbre
macbre commented May 24, 2024
View reviewed changes
modules/domComplexity/scope.js
@@ -92,13 +92,17 @@
})();

// count <iframe> tags
document.querySelectorAll("iframe").forEach(function (iframe) {
phantomas.incrMetric("iframesCount"); // @desc number of iframe nodes
const iframes = document.querySelectorAll("iframe");
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Query for the iframes just once.

@macbre macbre merged commit 40c92bb into devel May 24, 2024
11 checks passed
@macbre macbre deleted the puppeteer/22.10.0 branch May 24, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@macbre macbre

Labels
external dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@macbre