Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SlimerJS: fix all broken tests #541

Closed
macbre opened this issue Jul 11, 2015 · 2 comments
Closed

SlimerJS: fix all broken tests #541

macbre opened this issue Jul 11, 2015 · 2 comments
Labels
bug slimerjs-only
Milestone
Roadmap

Comments

@macbre
Copy link
Owner

macbre commented Jul 11, 2015 

$ PHANTOMAS_ENGINE=gecko npm test

> [email protected] test /home/macbre/github/phantomas
> vows --spec


  ♢ Integration tests 

  test server
    ✓ should be up and running
  /phantomas-scope.html
    ✓ should be generated
    ✓ should have "jsErrors" metric properly set
    ✓ should have "asserts" metric properly set
  /dom-operations.html
    ✓ should be generated
    ✓ should have "requests" metric properly set
    ✓ should have "cssCount" metric properly set
    ✓ should have "jsCount" metric properly set
    ✓ should have "domains" metric properly set
    ✓ should have "DOMqueries" metric properly set
    ✓ should have "DOMqueriesById" metric properly set
    ✓ should have "DOMqueriesByClassName" metric properly set
    ✓ should have "DOMqueriesByTagName" metric properly set
    ✓ should have "DOMqueriesByQuerySelectorAll" metric properly set
    ✓ should have "DOMinserts" metric properly set
    ✓ should have "DOMqueriesDuplicated" metric properly set
    ✓ should have "DOMqueriesAvoidable" metric properly set
    ✓ should have "DOMqueriesWithoutResults" metric properly set
  /dom-operations.html
    ✓ should be generated
    ✓ should have "DOMmutationsInserts" metric properly set
  /dom-complexity.html
    ✓ should be generated
    ✓ should have "bodyHTMLSize" metric properly set
    ✗ should have "commentsSize" metric properly set 
        » expected 12, 
    got  0 (===) // integration-test.js:52
    ✗ should have "DOMelementsCount" metric properly set 
        » expected 6, 
    got  0 (===) // integration-test.js:52
    ✗ should have "DOMelementMaxDepth" metric properly set 
        » expected 2, 
    got  0 (===) // integration-test.js:52
    ✓ should have "DOMidDuplicated" metric properly set
    ✗ should have "hiddenContentSize" metric properly set 
        » expected 10, 
    got  0 (===) // integration-test.js:52
    ✓ should have "imagesScaledDown" metric properly set
    ✗ should have "imagesWithoutDimensions" metric properly set 
        » expected 2, 
    got  0 (===) // integration-test.js:52
    ✗ should have "nodesWithInlineCSS" metric properly set 
        » expected 1, 
    got  0 (===) // integration-test.js:52
    ✗ should have "whiteSpacesSize" metric properly set 
        » expected 14, 
    got  0 (===) // integration-test.js:52
  /document-height.html
    ✓ should be generated
    ✓ should have "documentHeight" metric properly set
  /image-scaling.html
    ✓ should be generated
    ✗ should have "imagesScaledDown" metric properly set 
        » expected 2, 
    got  0 (===) // integration-test.js:52
    ✗ should have "imagesWithoutDimensions" metric properly set 
        » expected 3, 
    got  0 (===) // integration-test.js:52
  /dom-id.html
    ✓ should be generated
    ✗ should have "DOMidDuplicated" metric properly set 
        » expected 2, 
    got  0 (===) // integration-test.js:52
  Assertions and exit code
    ✗ should be generated 
        » Exit code matches the expected value // integration-test.js:46
    ✓ should have "requests" metric properly set
  /inline-css.html
    ✗ should be generated 
        » Exit code matches the expected value // integration-test.js:46
    ✓ should have "requests" metric properly set
    ✓ should have "cssParsingErrors" metric properly set
    ✓ should have "cssInlineStyles" metric properly set
    ✗ should have "cssLength" metric properly set 
        » expected 106, 
    got  undefined (===) // integration-test.js:52
    ✗ should have "cssRules" metric properly set 
        » expected 3, 
    got  undefined (===) // integration-test.js:52
    ✗ should have "cssImportants" metric properly set 
        » expected 1, 
    got  undefined (===) // integration-test.js:52
    ✓ should have "DOMqueries" metric properly set
  /broken-css.html
    ✗ should be generated 
        » Exit code matches the expected value // integration-test.js:46
    ✗ should have "cssParsingErrors" metric properly set 
        » expected 3, 
    got  0 (===) // integration-test.js:52
    ✗ should have "cssLength" metric properly set 
        » expected 39, 
    got  undefined (===) // integration-test.js:52
    ✗ should have "cssRules" metric properly set 
        » expected 1, 
    got  undefined (===) // integration-test.js:52
  /dom-operations.html
    ✗ should be generated 
        » Exit code matches the expected value // integration-test.js:46
    ✓ should have "cssParsingErrors" metric properly set
    ✗ should have "cssLength" metric properly set 
        » expected 22, 
    got  undefined (===) // integration-test.js:52
    ✗ should have "cssRules" metric properly set 
        » expected 1, 
    got  undefined (===) // integration-test.js:52
  /jquery.html
    ✓ should be generated
    ✓ should have "jQueryVersion" metric properly set
    ✓ should have "jQueryOnDOMReadyFunctions" metric properly set
    ✓ should have "jQueryWindowOnLoadFunctions" metric properly set
    ✓ should have "jQuerySizzleCalls" metric properly set
    ✗ should have "jQueryEventTriggers" metric properly set 
        » expected 2, 
    got  1 (===) // integration-test.js:52
    ✗ should have "eventsBound" metric properly set 
        » expected 7, 
    got  5 (===) // integration-test.js:52
    ✗ should have "eventsDispatched" metric properly set 
        » expected 1, 
    got  0 (===) // integration-test.js:52
    ✗ should have "eventsScrollBound" metric properly set 
        » expected 2, 
    got  0 (===) // integration-test.js:52
  /jquery-multiple.html
    ✓ should be generated
    ✓ should have "jQueryVersion" metric properly set
    ✓ should have "jQueryVersionsLoaded" metric properly set
    ✓ should have "jQueryOnDOMReadyFunctions" metric properly set
  /jquery-multiple.html (with --no-externals)
    ✓ should be generated
    ✗ should have "blockedRequests" metric properly set 
        » expected 2, 
    got  4 (===) // integration-test.js:52
    ✓ should have "domains" metric properly set
    ✓ should have "jsCount" metric properly set
  /jquery-reads-writes.html
    ✓ should be generated
    ✓ should have "jQueryDOMReads" metric properly set
    ✓ should have "jQueryDOMWrites" metric properly set
    ✓ should have "jQueryDOMWriteReadSwitches" metric properly set
  /jquery-old-version.html
    ✓ should be generated
    ✓ should have "jsErrors" metric properly set
    ✓ should have "jQueryVersion" metric properly set
    ✓ should have "jQuerySizzleCalls" metric properly set
    ✓ should have "jQueryEventTriggers" metric properly set
  / (--wait-for-selector)
    ✓ should be generated
    ✓ should have "DOMqueries" metric properly set
  /wait-for-selector.html
    ✓ should be generated
    ✗ should have "DOMelementsCount" metric properly set 
        » expected 4, 
    got  0 (===) // integration-test.js:52
  /wait-for-event.html
    ✓ should be generated
    ✓ should have "testFooBar" metric properly set
  /timing.html
    ✓ should be generated
    ✓ should have "requests" metric properly set
    ✓ should have "requestsToDomContentLoaded" metric properly set
    ✓ should have "domainsToDomContentLoaded" metric properly set
    ✓ should have "requestsToDomComplete" metric properly set
    ✓ should have "domainsToDomComplete" metric properly set
  /bottlenecks.html (--spy-eval)
    ✓ should be generated
    ✓ should have "documentWriteCalls" metric properly set
    ✓ should have "evalCalls" metric properly set
  /bottlenecks.html
    ✓ should be generated
    ✓ should have "documentWriteCalls" metric properly set
    ✓ should have "evalCalls" metric properly set
  /after-onload.html (--stop-at-onload)
    ✓ should be generated
    ✓ should have "imageCount" metric properly set
    ✓ should have "requests" metric properly set
  /after-onload.html
    ✓ should be generated
    ✓ should have "imageCount" metric properly set
    ✓ should have "requests" metric properly set
  /lazy-loadable-images.html
    ✓ should be generated
    ✗ should have "lazyLoadableImagesBelowTheFold" metric properly set 
        » expected 2, 
    got  0 (===) // integration-test.js:52
  /js-globals.html
    ✓ should be generated
    ✗ should have "globalVariables" metric properly set 
        » expected 3, 
    got  0 (===) // integration-test.js:52
    ✗ should have "globalVariablesFalsy" metric properly set 
        » expected 1, 
    got  0 (===) // integration-test.js:52
    ✓ should have "jsErrors" metric properly set

  ♢ CommonJS module 

  when not provided with URL
    ✗ should fail with err #255 
        » expected 255, 
    got  null (==) // module-test.js:17

...

✗ Broken » 231 honored ∙ 32 broken (166.109s)
@macbre macbre added this to the Roadmap milestone Jul 11, 2015
macbre added a commit that referenced this issue Jul 26, 2015
@macbre
Travis: run tests for SlimerJS as well (#541)
50a7ece
@macbre macbre mentioned this issue Jul 26, 2015
Closed
@macbre
Copy link
Owner Author

macbre commented Jul 26, 2015 

✗ Broken » 243 honored ∙ 18 broken (191.994s)

Travis

@macbre macbre modified the milestones: v1.13, Roadmap Sep 13, 2015
@macbre macbre modified the milestones: v1.13, Roadmap Oct 27, 2015
nathanial pushed a commit to nathanial/phantomas that referenced this issue Nov 3, 2016
@macbre @nathanial
Travis: run tests for SlimerJS as well (macbre#541)
c2d3479
@macbre
Copy link
Owner Author

macbre commented Jan 24, 2018

As we're switching to headless Chromium (#707), slimerjs will no longer be supported.

@macbre macbre closed this as completed Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug slimerjs-only
Projects
None yet
Milestone
Roadmap
Development

No branches or pull requests
1 participant
@macbre