Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subscription intent schemas #519

Open
wants to merge 6 commits into
base: v14-develop-stream
Choose a base branch
from
Open

Add subscription intent schemas #519

wants to merge 6 commits into from

Conversation

thanhtr
Copy link
Contributor

@thanhtr thanhtr commented Apr 16, 2020 •
edited
Loading

Will be closed when #559 merged

@thanhtr thanhtr force-pushed the feature/subscription-intent branch from 297da2c to f368302 Compare April 20, 2020 06:04
@thanhtr thanhtr changed the title Add subscription intent schemas. Bump version 13.2 Add subscription intent schemas. Bump version 13.4 Apr 20, 2020
@konker konker changed the title Add subscription intent schemas. Bump version 13.4 Add subscription intent schemas Jun 5, 2020
@thanhtr thanhtr force-pushed the feature/subscription-intent branch from 76bf564 to 2523eff Compare June 5, 2020 13:43
konker
konker suggested changes Jun 5, 2020
View reviewed changes
maas-schemas/package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "maas-schemas",
"version": "13.2.0",
"version": "13.4.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

14.2.0

maas-schemas/schemas/core/components/state.json Outdated
"DETAILS",
"CUSTOMISATION",
"PAYMENT",
"AUTH",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we consider merging AUTH and VERIFICATION into VERIFICATION?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which states would the Student ticket flow fall into?

maas-schemas/schemas/maas-backend/subscriptions/subscription-intent.json Outdated
"planAddons": {
"type": "array",
"items": {
"$ref": "#/definitions/itemId"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename this definition to addonId

maas-schemas/schemas/maas-backend/subscriptions/subscription-intent.json Show resolved Hide resolved
maas-schemas/schemas/maas-backend/subscriptions/subscription-intent.json Show resolved Hide resolved
maas-schemas/schemas/maas-backend/subscriptions/subscriptions-intents-list/response.json Outdated
@@ -0,0 +1,15 @@
{
"$id": "http://maasglobal.com/maas-backend/subscriptions/subscriptions-intents-list/response.json",
"description": "Response schema for subscriptions-intents-create",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy paste, intents-create -> intents-list

maas-schemas/schemas/maas-backend/subscriptions/subscriptions-intents-update-state/request.json
@@ -0,0 +1,31 @@
{
"$id": "http://maasglobal.com/maas-backend/subscriptions/subscriptions-intents-update-state/request.json",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Convert this to subscriptions-intents-update to be more general.

Copy link
Contributor Author

@thanhtr thanhtr Jun 8, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The service actually uses for updating state only, so maybe we could go through backend changes first then decide if we keep this or not

maas-schemas/schemas/maas-backend/subscriptions/subscriptions-intents-update-state/request.json Show resolved Hide resolved
...-schemas/schemas/maas-backend/subscriptions/subscriptions-intents-update-state/response.json
@@ -0,0 +1,12 @@
{
"$id": "http://maasglobal.com/maas-backend/subscriptions/subscriptions-intents-update-state/response.json",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Convert this to subscriptions-intents-update to be more general.

Copy link
Contributor Author

@thanhtr thanhtr Jun 8, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The service actually uses for updating state only, so maybe we could go through backend changes first then decide if we keep this or not

...-schemas/schemas/maas-backend/subscriptions/subscriptions-intents-update-state/response.json Outdated
@@ -0,0 +1,12 @@
{
"$id": "http://maasglobal.com/maas-backend/subscriptions/subscriptions-intents-update-state/response.json",
"description": "Response schema for subscriptions-intents-create",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy/paste error: intents-create -> intents-update.

@thanhtr thanhtr force-pushed the feature/subscription-intent branch 2 times, most recently from 0ece43e to b8ed275 Compare June 11, 2020 12:09
@thanhtr thanhtr changed the base branch from develop to v14-develop-stream July 2, 2020 11:35
@thanhtr thanhtr force-pushed the feature/subscription-intent branch from b8ed275 to fad294c Compare July 2, 2020 13:47
@thanhtr thanhtr mentioned this pull request Jul 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konker konker konker requested changes

Assignees
No one assigned
Labels
duplicate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thanhtr @konker