Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Workspace switching redux #287

Merged
merged 13 commits into from
Aug 20, 2024
Merged

feat: Workspace switching redux #287

merged 13 commits into from
Aug 20, 2024

Conversation

einsteinx2
Copy link
Contributor

Summary

This is an updated implementation of workspace switching. This significantly reduces the amount of time it will take to switch workspaces, since only upload batching is performed before the switch, and any remaining batches are uploaded later.

Testing Plan

  • Was this tested locally? If not, explain why.
  • Tested extensively using a test app sending events to two different workspaces in addition to unit tests

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@einsteinx2 einsteinx2 changed the title Feat/6593 workspace switching redux feat: Workspace switching redux Aug 19, 2024
BrandonStalnaker
BrandonStalnaker approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Walked through all the changes together, LGTM!

@einsteinx2 einsteinx2 merged commit 0c8da18 into development Aug 20, 2024
11 checks passed
mparticle-automation added a commit that referenced this pull request Sep 4, 2024
@mparticle-automation
chore(release): 8.27.0 [skip ci]
62f70e5 
# [8.27.0](v8.26.0...v8.27.0) (2024-09-04)

### Bug Fixes

* Properly attribute events when workspace switches on new launch ([#288](#288)) ([407749a](407749a))

### Features

* Workspace switching improvements ([#287](#287)) ([0c8da18](0c8da18))
@mparticle-automation
Copy link
Contributor

🎉 This PR is included in version 8.27.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrandonStalnaker BrandonStalnaker BrandonStalnaker approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@einsteinx2 @mparticle-automation @BrandonStalnaker