Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow uploadInterval to be set manually #175

Merged

Conversation

BrandonStalnaker
Copy link
Contributor

Summary

Implement a method to allow upload interval to be changed after SDK initialization.

Testing Plan

Added Unit tests and updated example app

Master Issue

Closes https://mparticle-eng.atlassian.net/browse/SQDSDKS-4948

mParticle-Apple-SDK/Include/mParticle.h Outdated Show resolved Hide resolved
mParticle-Apple-SDK/mParticle.m Outdated Show resolved Hide resolved
@BrandonStalnaker BrandonStalnaker dismissed einsteinx2’s stale review December 29, 2022 15:02

Added suggestions and replied to issues to provide context

Copy link
Contributor

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@peterjenkins peterjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrandonStalnaker BrandonStalnaker merged commit 8d2c5cf into development Jan 9, 2023
@BrandonStalnaker BrandonStalnaker deleted the feat/Allow-Upload-Interval-To-Be-Set-Manually branch January 9, 2023 18:01
@mparticle-automation
Copy link
Contributor

🎉 This PR is included in version 8.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

mparticle-automation added a commit that referenced this pull request Jan 10, 2023
# [8.10.0](v8.9.2...v8.10.0) (2023-01-10)

### Features

* Add wrapper sdk info setter ([#174](#174)) ([c2ca247](c2ca247))
* Allow uploadInterval to be set manually ([#175](#175)) ([8d2c5cf](8d2c5cf))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants