Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SQDSDK-5597 - Get ad id in background thread #463

Merged
merged 4 commits into from
Jan 29, 2024
Merged

fix: SQDSDK-5597 - Get ad id in background thread #463

merged 4 commits into from
Jan 29, 2024

Conversation

markvdouw
Copy link

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Move the getAdIdInfo to be triggered in a background thread

Testing Plan

  • Was this tested locally? If not, explain why.
  • Added a log printing the current thread in which the fun was being called (which was then removed prior to commit)
Screen Shot 2023-12-13 at 09 11 52

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

samdozor
samdozor requested changes Dec 17, 2023
View reviewed changes
Copy link
Member

@samdozor samdozor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you mind also annotating the getAdIdInfo method with @workerthread (or whatever the syntax is)?

android-core/src/main/java/com/mparticle/internal/MPUtility.java Outdated Show resolved Hide resolved
@markvdouw
Copy link
Author

would you mind also annotating the getAdIdInfo method with @workerthread (or whatever the syntax is)?

This is already done

markvdouw
markvdouw commented Jan 9, 2024
View reviewed changes
Copy link
Author

@markvdouw markvdouw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already has the @workerthread annotation in line 128

@markvdouw markvdouw force-pushed the fix/SQDSDKS-5597_get_ad_id_in_background branch from d46eb31 to 56b9527 Compare January 10, 2024 11:37
@markvdouw markvdouw force-pushed the fix/SQDSDKS-5597_get_ad_id_in_background branch from 56b9527 to 9670b4d Compare January 17, 2024 13:32
@markvdouw markvdouw force-pushed the fix/SQDSDKS-5597_get_ad_id_in_background branch from 9670b4d to 2f987a4 Compare January 17, 2024 14:58
@markvdouw markvdouw merged commit 679d987 into development Jan 29, 2024
22 of 23 checks passed
@markvdouw markvdouw deleted the fix/SQDSDKS-5597_get_ad_id_in_background branch January 29, 2024 17:25
mparticle-automation added a commit that referenced this pull request Feb 6, 2024
@mparticle-automation
chore: 5.55.1 (release)
180e505 
## [5.55.1](v5.55.0...v5.55.1) (2024-02-06)

### Bug Fixes

* SQDSDK-5597 - Get ad id in background thread ([#463](#463)) ([679d987](679d987))

### Updates & Maintenance

* Update submodules ([d4f2512](d4f2512))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 5.55.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdozor samdozor samdozor approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markvdouw @mparticle-automation @samdozor