Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add bannerFreemium icon #517

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

nrmerlis
Copy link
Contributor

@nrmerlis nrmerlis commented Dec 17, 2024

Instructions

No need to keep instructions in the final PR description

  1. PR target branch should be against main
  2. PR title prefix should state semantic value for the change, usually feat:, fix: or chore:. Source.
  3. PR branch prefix should state the same as the above with a /, usually feat/, fix/ or chore/. Source.

Summary

bannerFremium icon added to the library. This icon is going to be used in Indicative.

https://www.figma.com/design/sOJ8jcYIPl5wyhQMNpDRuS/Analytics-for-all?node-id=392-4733&t=PPb3lgWWglmpPWk1-4

Testing Plan

  • Was this tested locally? If not, explain why.
  • {explain how this has been tested, and what, if any, additional testing should be done}

The icon shows up on Storybook!

image

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Copy link

github-actions bot commented Dec 17, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://mParticle.github.io/aquarium/pr-preview/pr-517/
on branch gh-pages at 2024-12-18 15:08 UTC

@nrmerlis nrmerlis changed the title Feat/ui3 dm 1907 add banner freemium icon Feat: Add bannerFreemium icon Dec 17, 2024
@tibuurcio
Copy link
Collaborator

@nrmerlis @gabyzif heads up there's a breaking change in a previous version from Aquarium that will need to be addressed before this gets used in Analytics from a new version. Work is being tracked here: https://mparticle-eng.atlassian.net/browse/UNI-1277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants