-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: utilize generics in UserPreferencesService #504
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
8e00699
feat: add data attribute to UserPreference
danielsiemens c0acc10
feat: make data unknown
danielsiemens d60387a
chore: add coverage package for vitest
danielsiemens fd3a09f
fix: rm comments
danielsiemens 4bf0ab2
chore: update types
danielsiemens ac74474
fix: data is optional on setPreference
danielsiemens 173c105
fix: tighter bound on `data` type
danielsiemens 556e135
chore: type fix
danielsiemens 9b212c6
feat: change ups to be generic
gmarques-mParticle ee53528
Merge branch 'feat/ups-generic-typed' into feat/uni-1253-new
danielsiemens 196f13c
chore: separate Composite and fix type errors
danielsiemens 3fe403b
chore: rm old files, fix types on test
danielsiemens 3ecbfbe
chore: move types to separate files
danielsiemens ea9e09b
fix: composite user preferences tests
danielsiemens 961d069
fix: exports
danielsiemens f3f159a
chore: exports
danielsiemens 65ef65d
chore: rm unused files
danielsiemens b2b5fd4
fix: export
danielsiemens 1f3f321
Merge branch 'main' into feat/uni-1253-new
danielsiemens File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added so we can check unit test coverage with vitest. This is a dev dependency