Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate mp-query-item tokens #476

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

jared-dickman
Copy link
Collaborator

Summary

remove --mp-query-item-* variables, and prefer underlying tokens instead

Testing Plan

  • validate in storybook
  • validated with design
  • see figma for underlying token mapping
  • Was this tested locally? If not, explain why.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@ilyusha
Copy link
Collaborator

ilyusha commented Oct 25, 2024

Review Forge

Click Here for AI Insights

Copy link

github-actions bot commented Oct 25, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-28 18:02 UTC

@jared-dickman jared-dickman merged commit d8b1faf into main Oct 28, 2024
9 checks passed
mparticle-automation added a commit that referenced this pull request Oct 29, 2024
# [1.34.0-fix-semantic-release.1](v1.33.3-fix-semantic-release.4...v1.34.0-fix-semantic-release.1) (2024-10-29)

### Features

* deprecate mp-query-item tokens ([#476](#476)) ([d8b1faf](d8b1faf))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 1.34.0-fix-semantic-release.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

mparticle-automation added a commit that referenced this pull request Oct 29, 2024
# [1.34.0](v1.33.2...v1.34.0) (2024-10-29)

### Features

* deprecate mp-query-item tokens ([#476](#476)) ([d8b1faf](d8b1faf))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 1.34.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants