Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix workspace selector's singout button styles affected by removing override in Nancy #447

Closed
wants to merge 21 commits into from

Conversation

gabyzif
Copy link
Contributor

@gabyzif gabyzif commented Oct 11, 2024

Summary

The change ensures that the button styling aligns with the expected design without the need for additional overrides in Nancy.

Testing Plan

  • Was this tested locally? If not, explain why.
Platform Tested
Nancy Yes
Analytics WIP
Cortex No

@ilyusha
Copy link
Collaborator

ilyusha commented Oct 11, 2024

Review Forge

Click Here for AI Insights

Copy link

github-actions bot commented Oct 11, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://mParticle.github.io/aquarium/pr-preview/pr-447/
on branch gh-pages at 2024-10-14 16:27 UTC

@gabyzif gabyzif changed the title Chore/add styles from nancy chore: add styles to workspace button to remove override in Nancy Oct 14, 2024
@gabyzif gabyzif changed the title chore: add styles to workspace button to remove override in Nancy chore: fix workspace selector's singout button styles affected by removing override in Nancy Oct 14, 2024
@gabyzif gabyzif closed this Oct 14, 2024
@gabyzif gabyzif deleted the chore/add-styles-from-nancy branch October 14, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants