Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate Dropdown and add docs to icon #426

Closed
wants to merge 2 commits into from

Conversation

gabyzif
Copy link
Contributor

@gabyzif gabyzif commented Sep 26, 2024

Summary

This PR adds deprecated notice to the Dropdown component and updates the icon documentation

Testing Plan

  • Was this tested locally? If not, explain why.
  • {explain how this has been tested, and what, if any, additional testing should be done}

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@ilyusha
Copy link
Collaborator

ilyusha commented Sep 26, 2024

Review Forge

Click Here for AI Insights

Copy link

github-actions bot commented Sep 26, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-09-26 16:36 UTC

Copy link
Collaborator

@tibuurcio tibuurcio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good but not a feat:, let's change that and should be good to go!

@gabyzif gabyzif closed this Sep 26, 2024
@gabyzif gabyzif deleted the feat/deprecation-icon-docs branch September 26, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants