Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Align button content to the center #243

Merged
merged 9 commits into from
May 23, 2024
Merged

fix: Align button content to the center #243

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7195278
align button content to the center
gabyzif May 23, 2024
52da1a1
update button class
gabyzif May 23, 2024
ebe07c6
make the button flex only when it has an icon
gabyzif May 23, 2024
35fae01
add utility classes
gabyzif May 23, 2024
ed29667
add important for consitency
gabyzif May 23, 2024
f4e8b83
Update src/utils/utils.css
jared-dickman May 23, 2024
030b6ac
Update src/components/general/Button/Button.tsx
jared-dickman May 23, 2024
9926c0b
cleanup
gabyzif May 23, 2024
8334912
Merge branch 'fix/button-aligment' of https://github.com/mParticle/aq…
gabyzif May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/components/general/Button/Button.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,13 @@ export const WithIcon: Story = {
},
}

export const WithIconSM: Story = {
args: {
type: 'default',
icon: <Icon name="mpLogo" size="sm" />,
},
}

export const Loading: Story = {
args: {
loading: true,
Expand Down
4 changes: 3 additions & 1 deletion src/components/general/Button/Button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ export interface IButtonProps extends AntButtonProps {}
export const Button = (props: IButtonProps) => {
return (
<ConfigProvider>
<AntButton {...props}>{props.children}</AntButton>
<AntButton {...props} className={props.icon ? 'u-display-flex u-align-items-center ' : ''}>
jared-dickman marked this conversation as resolved.
Show resolved Hide resolved
{props.children}
</AntButton>
</ConfigProvider>
)
}
Expand Down
8 changes: 8 additions & 0 deletions src/utils/utils.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
.u-display-none {
display: none !important;
}

.u-display-flex {
display: flex !important;
}

.u-align-items-center{
jared-dickman marked this conversation as resolved.
Show resolved Hide resolved
align-items: center !important;
}
Loading