Skip to content

Commit

Permalink
fix: update deprecated icons
Browse files Browse the repository at this point in the history
  • Loading branch information
gabyzif committed Aug 15, 2024
1 parent aca0a3b commit a84954d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
5 changes: 3 additions & 2 deletions src/components/general/Icon/Icon.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export const IconTable: React.FC<IIconProps> = ({ color = 'black', size = 'lg',
return (
<Flex vertical align="center" key={iconName}>
<Icon name={iconName} size={size} color={color} variant={variant} />
<p style={{ fontFamily: 'monospace', ...textStyle }}>
<p style={{ fontFamily: 'monospace', textAlign: 'center', ...textStyle }}>
{isDeprecated ? 'deprecated ' : ''}
{iconName}
</p>
Expand All @@ -45,7 +45,8 @@ The \`IconTable\` component is used to display a table of all available icons in
- \`variant\`: The variant of the icon. Available options are \`light\` and \`duo-tone\`.
#### Updating Icons
To update the icons:
The icon SVG and icon name are provided by the Design team. and the svg must be minified.
1. **Add New Icons**: Add the new icon SVGs to the \`src/constants/Icons\` directory. The icons should be curated by Design and the svg must be minified.
2. **Update Icon Constants**: Update the \`Icons\` object in \`src/constants/Icons\` to include the new icons.
Expand Down
4 changes: 3 additions & 1 deletion src/constants/Icons.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ export const Icons: Record<IconNames, IconOptions> = {
chartColumn: {
light: ChartColumnIcon,
default: 'light',
deprecated: 'this icon is not used anymore',
},
chartLine: {
light: ChartLineIcon,
Expand Down Expand Up @@ -131,10 +132,12 @@ export const Icons: Record<IconNames, IconOptions> = {
connections: {
light: ConnectionsIcon,
default: 'light',
deprecated: 'this icon is not used anymore',
},
database: {
light: DatabaseIcon,
default: 'light',
deprecated: 'this icon is not used anymore',
},
dsr: {
light: DsrIcon,
Expand Down Expand Up @@ -199,7 +202,6 @@ export const Icons: Record<IconNames, IconOptions> = {
favorite: {
light: HeartIcon,
default: 'light',
deprecated: 'favorite',
},
help: {
light: HelpIcon,
Expand Down

0 comments on commit a84954d

Please sign in to comment.