Enabled P/Invoke source generation with LibraryImport. #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoFtZ
force-pushed
the
feature/library-import
branch
from
44c962b
to
2fe98b2
Compare
m4rs-mt
approved these changes
Mar 13, 2023
MoFtZ
force-pushed
the
feature/library-import
branch
from
2fe98b2
to
6e5cdf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.NET 7 introduced a replacement for
DllImportthat uses source generation.This PR updates CuRand and CuBlas implementations to use the ILGPU DLL Library Import helper. Note that this introduces a breaking API change -
CuBlasAPIVersionandCuRandAPIVersionare moved from theILGPU.Algorithms.Cudanamespace toILGPU.Algorithms.Cuda.API.Then, that helper code has been updated to generate the new
LibraryImportattribute for .NET 7 or greater. The string handling has been updated to the newStringMarshallingstyle, with a fallback behaviour.