Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Website improvements for mobile #1140

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Website improvements for mobile #1140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e66ce32
index page : Improve responsiveness of Ready to get Started section
naskio Dec 18, 2023
e45d96f
Docs: Fix contribute CTA
naskio Dec 18, 2023
319bd16
Docs layout: more space for content + don't move content when sidebar…
naskio Dec 18, 2023
0be4ad0
Docs layout: footer over sidebar when collapsed
naskio Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Site/_includes/doc/contribute.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{% if site.social_links.github and site.gh_contribute %}
<div class="f5 contribution">
<div class="col col-md-11 col-lg-10 col-xl-7 p-5 mt-5 contribution">
<h2>Help us make these docs great!</h2>
<p>All {{ site.name | default: 'the' }} docs are open source. See something that's wrong or unclear? Submit a
pull request.</p>
Expand Down
29 changes: 16 additions & 13 deletions Site/_sass/extras-styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@
}

.features-body > tr:nth-child(even) {
background-color: #00000004;
background-color: #00000004;
}

.features-body-col {
Expand Down Expand Up @@ -255,13 +255,14 @@
overflow-y: scroll;
height: calc(100vh - 100px);
background: #002C5A;
z-index: 200;
z-index: 301;
padding: 0;
}

#sidebar.sidebar-collapsed {
transform: translateX(calc(-75% - 12px)); // calculated from column ratios (9/12) and padding on sidebar header
overflow: hidden; // disable scrolling
transform: translateX(calc(-75% - 12px)); // calculated from column ratios (9/12) and padding on sidebar header
z-index: 299;
overflow: hidden; // disable scrolling
}

#sidebar.sidebar-animated {
Expand Down Expand Up @@ -298,15 +299,21 @@
}

#wiki-main {
margin-left: 325px;
padding: 32px 50px 130px 50px;
padding: 16px;
min-height: 92vh;
}

#wiki-main.sidebar-collapsed {
#wiki-main, #wiki-main.sidebar-collapsed {
margin-left: 70px;
}

@media (min-width: 576px) {
#wiki-main {
padding: 32px 50px 130px 50px;
margin-left: 325px;
}
}

#wiki-main.sidebar-animated {
@include sidebar-collapse-transition(margin-left);
}
Expand Down Expand Up @@ -334,11 +341,8 @@
}

.contribution {
margin-top: 60px;
box-shadow: 0 0 25px 0 rgba(0, 0, 0, 0.1);
width: 50%;
padding: 50px 30px;
border-radius: 6px;
border-radius: 8px;
}

.wiki a.btn {
Expand Down Expand Up @@ -374,9 +378,8 @@
margin-right: 4px;
}

.wiki #footer {
#footer {
z-index: 300;
position: relative;
}

/***** DOC LAYOUT *****/
Expand Down
10 changes: 6 additions & 4 deletions Site/assets/css/doc.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,14 @@
@import 'override-colors';
@import 'sidebar-collapse';

#breadcrumbs .container {
margin-left: 340px;
#breadcrumbs .container, #breadcrumbs .container.sidebar-collapsed {
margin-left: 85px;
}

#breadcrumbs .container.sidebar-collapsed {
margin-left: 85px;
@media (min-width: 576px) {
#breadcrumbs .container {
margin-left: 340px;
}
}

#breadcrumbs .container.sidebar-animated {
Expand Down
2 changes: 1 addition & 1 deletion Site/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ <h3>Ready to get started?</h3>
</div>
</div>
<div class="row">
<div class="col-lg-6">
<div class="col-lg-6 text-center">
<a class="cta-btn cta-btn-1" href="{{ docs_url }}">Documentation</a>
<a class="cta-btn" href="{{ social.github | default: '#' }}/" target="_blank"><i
class="bx bxl-github"></i>Github</a>
Expand Down
Loading