Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding SQLITE_ENABLE_DBSTAT_VTAB to defines #101

Closed
wants to merge 1 commit into from

Conversation

mikeburgh
Copy link
Contributor

This enables the virtual stats table in SQLite https://www.sqlite.org/dbstat.html

@m4heshd
Copy link
Owner

m4heshd commented Jul 23, 2024

Hey, Thank you for the PR.

Unfortunately, there's a hoop you gotta jump through first.

Can you kindly open this same PR on the upstream? I'm doing everything in my power to keep the build process and the API as identical as possible to BS3 for debugging purposes. The native key() and rekey() functions have already given me enough pain.

@m4heshd m4heshd added the blocked-by-upstream 🛑 This issue is waiting for a fix on a depending library label Jul 23, 2024
@mikeburgh
Copy link
Contributor Author

No problems, that's been done: WiseLibs/better-sqlite3#1228

@mikeburgh mikeburgh closed this Jul 23, 2024
@mikeburgh mikeburgh deleted the dbstats-vtab branch July 23, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked-by-upstream 🛑 This issue is waiting for a fix on a depending library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants