-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix inconsistent time format #42
base: master
Are you sure you want to change the base?
Conversation
I applied your fix and I can now see the AM and PM on the UI when I choose time. However, the value in onchanged or onsaved is captured without AM or PM. Here's my code:
|
@iesmail-znz Thanks for checking, I'll take a look. Could you please try to pass a controller as I shown in my example and check it's text? Sure that it works this way |
@iesmail-znz I've pushed a fix and checked with your configuration - looks good now. Could you please confirm? |
I'm having the same problem @iesmail-znz has with the onChanged and onSaved. Is this gonna be merge/fix any time soon? |
I'm trying to print AM PM in console or inside a string but i can only be able to get the time but without AM PM, but in the ui i can able to see AM PM |
This PR fixes inconsistent time formats when use
DateTimePickerType.time
with 12 hour format. In current version, inputs will show time in formatHH;mm a
until you edit it manually.So, when you use widget like this:
It will be shown like this when screen loaded
when you pick another time and click 'OK' label will be shown like this:
Also, when you use controller with current plugin version - it's text may be different based on - did you select another time or not. That's why I call
_effectiveController?.text = _sTime + _sPeriod;
ininitValues()
Also, it will throw an exception when you try to pass a controller like this:
this PR fixes it as well