This repository has been archived by the owner on Apr 8, 2019. It is now read-only.
Move opentracing util to m3x #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #214 +/- ##
==========================================
- Coverage 78.32% 78.31% -0.01%
==========================================
Files 87 88 +1
Lines 3469 3487 +18
==========================================
+ Hits 2717 2731 +14
- Misses 684 688 +4
Partials 68 68Continue to review full report at Codecov.
|
benraskin92
changed the title
benraskin92
force-pushed
the
braskin/move_opentracing
branch
from
49133f0 to
443401e
Compare
arnikola
approved these changes
Apr 1, 2019
prateek
reviewed
Apr 1, 2019
opentracing/tracing_test.go
Outdated
| @@ -18,7 +18,7 @@ | |||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | |||
| // THE SOFTWARE. | |||
|
|
|||
| package instrument | |||
| package opentracingutil | |||
There was a problem hiding this comment.
nit: rename so as to keep the package name the same as the folder name.
prateek
reviewed
Apr 1, 2019
opentracing/context.go
Outdated
|
|
||
| "github.com/opentracing/opentracing-go" | ||
| "github.com/opentracing/opentracing-go/log" | ||
| "golang.org/x/net/context" |
There was a problem hiding this comment.
any reason to prefer this over the standard lib "context" here?
There was a problem hiding this comment.
Nope - I'll switch.
prateek
reviewed
Apr 1, 2019
opentracing/context.go
Outdated
| return span, opentracing.ContextWithSpan(ctx, span) | ||
| } | ||
|
|
||
| // Time is a log.Field for time.Time values. It translates to RF3339 formatted time strings. |
There was a problem hiding this comment.
nit: RFC3339. Maybe also add an example of what that means, e.g. "2019-04-01T15:04:05Z07:00"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.