Improve M3DB session performance part 1: Pool goroutines in host queues #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateek
reviewed
Sep 29, 2018
glide.yaml
Outdated
| @@ -220,4 +220,3 @@ testImport: | |||
| version: b433bbd6d743c1854040b39062a3916ed5f78fe8 | |||
|
|
|||
| - package: github.com/leanovate/gopter | |||
| version: f0356731348c8fffa27bab27c37ec8be5b0662c8 | |||
prateek
reviewed
Sep 29, 2018
src/dbnode/client/host_queue.go
Outdated
|
|
||
| workerPoolOpts := xsync.NewPooledWorkerPoolOptions(). | ||
| SetGrowOnDemand(true). | ||
| SetKillWorkerProbability(0.01). |
There was a problem hiding this comment.
nit: use a const for this
Codecov Report
@@ Coverage Diff @@
## master #985 +/- ##
==========================================
- Coverage 77.86% 77.81% -0.06%
==========================================
Files 411 411
Lines 34469 34490 +21
==========================================
- Hits 26839 26838 -1
- Misses 5766 5782 +16
- Partials 1864 1870 +6
Continue to review full report at Codecov.
|
prateek
reviewed
Sep 29, 2018
glide.lock
Outdated
| @@ -600,8 +613,6 @@ imports: | |||
| - codes | |||
| - name: gopkg.in/yaml.v2 | |||
| version: 5420a8b6744d3b0345ab293f6fcba19c978f1183 | |||
| repo: https://github.com/go-yaml/yaml.git | |||
There was a problem hiding this comment.
retain this (add in .yaml if you have to), gopkg.in is a shit show and breaks randomly
prateek
reviewed
Sep 29, 2018
| - name: gopkg.in/go-playground/validator.v9 | ||
| version: a021b2ec9a8a8bb970f3f15bc42617cb520e8a64 | ||
| repo: https://github.com/go-playground/validator.git |
prateek
reviewed
Sep 29, 2018
glide.lock
Outdated
| imports: | ||
| - name: "" |
There was a problem hiding this comment.
is glide just phoning it in now? no name?
richardartoul
force-pushed
the
ra/m3-sess-perf-improvement
branch
from
ed3b6a9 to
1b13b70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.