Eliminate locking from postings lists #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #889 +/- ##
==========================================
+ Coverage 55.8% 78.6% +22.79%
==========================================
Files 392 396 +4
Lines 33328 33479 +151
==========================================
+ Hits 18599 26316 +7717
+ Misses 13067 5363 -7704
- Partials 1662 1800 +138
Continue to review full report at Codecov.
|
jeromefroe
approved these changes
Sep 7, 2018
| @@ -37,9 +36,8 @@ var ( | |||
| errIteratorClosed = errors.New("iterator has been closed") | |||
| ) | |||
|
|
|||
| // postingsList wraps a Roaring Bitmap with a mutex for thread safety. | |||
| // postingsList wraps a Roaring Bitmap with the m3ninx pl API. | |||
There was a problem hiding this comment.
worth calling out that it's not goroutine-safe?
There was a problem hiding this comment.
Sure, will do in a follow up change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the segments/readers do the necessary locking external to the postings list, so we don't need the locking inside the postings lists on top of that.