Add m3ninx query prop tests #885
Conversation
Codecov Report
@@ Coverage Diff @@
## master #885 +/- ##
===========================================
+ Coverage 55.8% 78.73% +22.92%
===========================================
Files 392 397 +5
Lines 33328 33523 +195
===========================================
+ Hits 18599 26394 +7795
+ Misses 13067 5317 -7750
- Partials 1662 1812 +150
Continue to review full report at Codecov.
|
prateek
force-pushed
the
prateek/m3ninx/proptest-queries
branch
from
4c2fc94 to
e6506fd
Compare
prateek
force-pushed
the
prateek/m3ninx/proptest-queries
branch
2 times, most recently
from
a8d2f77 to
91d80d0
Compare
src/m3ninx/index/regexp.go
Outdated
| ) | ||
|
|
||
| // CompileRegex compiles the provided regexp. | ||
| func CompileRegex(r []byte) (CompiledRegex, error) { |
There was a problem hiding this comment.
Hey as we briefly discussed, could we instead use validation and just ensure that callers have fully anchored their regexps?
It is more explicit that way, rather than coercing their regexps into being fully anchored.
I don't mind too much either way, but that seems less magical just responding with an error saying "hey please fully anchor your regexp with "^pattern$".
richardartoul
force-pushed
the
master
branch
from
2883443 to
2cf04be
Compare
| return nil, errReaderNilRegex | ||
| } | ||
|
|
||
| pl, err := r.segment.matchRegexp(field, compileRE) |
There was a problem hiding this comment.
nit: Instead perhaps just return r.segment.matchRegexp(field, compileRE)?
src/m3ninx/index/regexp.go
Outdated
| @@ -0,0 +1,62 @@ | |||
| // Copyright (c) 2017 Uber Technologies, Inc. | |||
prateek
force-pushed
the
prateek/m3ninx/proptest-queries
branch
from
91d80d0 to
26f4ff7
Compare
prateek
changed the base branch from
master
to
prateek/m3ninx/rework-regexp-queries
| simpleSeg := newTestMemSegment(t, lotsTestDocuments) | ||
| fstSeg := fst.ToTestSegment(t, simpleSeg, fstOptions) | ||
|
|
||
| properties.Property("Simple & FST Segments Query the same results", prop.ForAll( |
There was a problem hiding this comment.
Ah nice, this is pretty great.
prateek
force-pushed
the
prateek/m3ninx/rework-regexp-queries
branch
from
4feeba8 to
004910f
Compare
prateek
force-pushed
the
prateek/m3ninx/proptest-queries
branch
from
2528c57 to
47d648f
Compare
prateek
changed the base branch from
prateek/m3ninx/rework-regexp-queries
to
master
Pending: